Moodle
  1. Moodle
  2. MDL-6332

Once 1.7 branch was generated, drop UTF-8 migration support from HEAD

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: Unicode
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE
    • Rank:
      34227

      Description

      Once the MOODLE_17_STABLE branch was generated we'll drop all the UTF-8 migration stuff from HEAD.

      Apart from that, some more things will be done:

      • Under 17_STABLE and HEAD, add one new check to the environment stuff to allow users to check that they DB is unicode, informing about it. This will, automatically, forbid installations using install.php
      • Under HEAD, add one more check at the beginning of the process, looking for unicode DB. This will forbid installations not using install.php (those done by manually creating the config.php file).
      • Under HEAD, before executing any upgrade, check that the DB is unicode.
      • Document clearly that running under Unicode is mandatory to be able to run 1.8.

      With this measures, everyone installing/upgrading to 1.8 will need to have one unicode db. That's the objective to safely drop migration stuff.

      1. env1.patch
        6 kB
        Petr Škoda
      2. environment.xml
        3 kB
        Yu Zhang
      3. environmentlib.php
        35 kB
        Yu Zhang

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Assigned to Yu, for the future....

          Show
          Eloy Lafuente (stronk7) added a comment - Assigned to Yu, for the future....
          Hide
          Yu Zhang added a comment -

          Hi Eloy,

          This is the environment checking code I have modified so far, could you take a look and let me know if this is ok to committ into stable and HEAD? Thanks.

          Cheers,

          Yu

          Show
          Yu Zhang added a comment - Hi Eloy, This is the environment checking code I have modified so far, could you take a look and let me know if this is ok to committ into stable and HEAD? Thanks. Cheers, Yu
          Hide
          Petr Škoda added a comment -

          I have fixed the code a bit and added messages into lang pack.

          Eloy proposed to add new function type to environment checks - I was not able to it today including proper testing 1.8?

          Show
          Petr Škoda added a comment - I have fixed the code a bit and added messages into lang pack. Eloy proposed to add new function type to environment checks - I was not able to it today including proper testing 1.8?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Oki. NP for me. We can safely create that new environment feature later (1.7.1...., 1.8...).

          Then I +1 to include this specific Unicode check right now. I really think it's better for moodlers to know about that ASAP.

          Show
          Eloy Lafuente (stronk7) added a comment - Oki. NP for me. We can safely create that new environment feature later (1.7.1...., 1.8...). Then I +1 to include this specific Unicode check right now. I really think it's better for moodlers to know about that ASAP.
          Hide
          Petr Škoda added a comment -

          waiting for lang review before commit

          Show
          Petr Škoda added a comment - waiting for lang review before commit
          Hide
          Martin Dougiamas added a comment -

          Petr's committed the unicode checking into 1.7 and 1.8 and it works for me.

          Show
          Martin Dougiamas added a comment - Petr's committed the unicode checking into 1.7 and 1.8 and it works for me.
          Hide
          Yu Zhang added a comment -

          All dropped now, will close this in a few days if no objection....

          Show
          Yu Zhang added a comment - All dropped now, will close this in a few days if no objection....
          Hide
          Yu Zhang added a comment -

          Resolving this now, took out all the dbencoding test stuff in install.php, will rely on environment testing. The code to test 'oci8po' seems different (a little shorter) in setuplib (setup_is_unicode()), so please check if it's sufficient.

          Show
          Yu Zhang added a comment - Resolving this now, took out all the dbencoding test stuff in install.php, will rely on environment testing. The code to test 'oci8po' seems different (a little shorter) in setuplib (setup_is_unicode()), so please check if it's sufficient.
          Hide
          Petr Škoda added a comment -

          reopening more task ahead

          Show
          Petr Škoda added a comment - reopening more task ahead
          Hide
          Petr Škoda added a comment -

          subtask finished, reclosing now...

          Show
          Petr Škoda added a comment - subtask finished, reclosing now...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Huge change, clap, clap, clap.

          Now we are only and exclusively 100% UTF8!

          What reminds me that one of the important things to solve is the specification of the charset in all the Moodle interactions with external files/DBs (authentication, enrolment, file load....).

          I've been searching the tracker because I'm pretty sure that one bug about this existed but I haven't been able to find it. Uhm...

          Show
          Eloy Lafuente (stronk7) added a comment - Huge change, clap, clap, clap. Now we are only and exclusively 100% UTF8! What reminds me that one of the important things to solve is the specification of the charset in all the Moodle interactions with external files/DBs (authentication, enrolment, file load....). I've been searching the tracker because I'm pretty sure that one bug about this existed but I haven't been able to find it. Uhm...
          Hide
          Petr Škoda added a comment -

          reopening and adding new task to get rid of get_string("thischarset");

          Show
          Petr Škoda added a comment - reopening and adding new task to get rid of get_string("thischarset");
          Hide
          Petr Škoda added a comment -

          reclosing

          Show
          Petr Škoda added a comment - reclosing

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: