Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6334

Unnecessary group menu in Feedback popup window

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.1, 1.6.2, 1.7
    • Fix Version/s: 1.6.3, 1.7
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE

      Description

      We are in assignment submissions, viewing the list. Clicking in grade/update opens a popup window for processing teh Feedback for a single student. However, teh first element in the popup is a menu to select a group. This doesn't make sense, the popup window contains data for a single submission for a single student. Theer is no dneed to change the current group there. Even worst, if the group is changed you end with the whole submissions table within the popup window.

      The error in in mod/assignment/lib.php, function display_submission() (and possibly in any overrided display_submission() method in plugins)

      By line 807 these lines should be deleted:
      if ($groupmode = groupmode($course, $cm))

      { // Groups are being used $currentgroup = setup_and_print_groups($course, $groupmode, 'submissions.php?id='.$this->cm->id); }

      else

      { $currentgroup = false; }

      That's all.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          Thanks!

          I replaced it with:

          $currentgroup = get_current_group($course->id);

          in 1.6.3 and 1.7

          Show
          dougiamas Martin Dougiamas added a comment - Thanks! I replaced it with: $currentgroup = get_current_group($course->id); in 1.6.3 and 1.7
          Hide
          sbourget Stephen Bourget added a comment -

          Verified in Moodle 1.7beta

          Closing

          Show
          sbourget Stephen Bourget added a comment - Verified in Moodle 1.7beta Closing

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Oct/06