Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63349

Assignment: Annotate PDF - Rotate submitted image automatically

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Take 4 pictures of a document: each time, rotate camera 90 degrees, mark the upright position of the document ( e.g an arrow point upward from the ground)
      2. Login as admin.
      3. Create 3 users (s, s2 and s3).
      4. Create a course and enrol s1, s2 and s3 as students.
      5. Create an assignment activity in the course with "File submissions" and  "Annotate PDF" enabled.

      Scenario 1: With converters disabled

      1. Login as admin.
      2. Go to "Site administration / Plugins / Document converters / Manage document converters" and disable all file converters.
      3. Logout.
      4. Login as student s1.
      5. Submit the pictures to the assignment.
      6. Login as admin.
      7. Grade the submission.

      Scenario 2: With UNOCONV converter enabled

      1. Login as admin.
      2. Go to "Site administration / Plugins / Document converters / Manage document converters" and  enable the Unoconv file converter.
      3. Logout.
      4. Login as student s2.
      5. Repeat the above steps (5 to 7).

      Scenario 3: With Google Drive converter enabled

      1. Login as admin.
      2. Go to "Site administration / Plugins / Document converters / Manage document converters". Enable the "Google Drive" converter and disable the Unoconv file converter.
      3. Logout.
      4. Login as student s3.
      5. Repeat the above steps in scenario 1 (5 to 7).

       

      Expected behaviour in all the scenarios:

      1. The JPG files should be converted to PDF files.
      2. The arrow lines should point up in 4 documents.

       

      Show
      Setup Take 4 pictures of a document: each time, rotate camera 90 degrees, mark the upright position of the document ( e.g an arrow point upward from the ground) Login as admin. Create 3 users (s, s2 and s3). Create a course and enrol s1, s2 and s3 as students. Create an assignment activity in the course with "File submissions" and  "Annotate PDF" enabled. Scenario 1: With converters disabled Login as admin. Go to "Site administration / Plugins / Document converters / Manage document converters" and disable all file converters. Logout. Login as student s1. Submit the pictures to the assignment. Login as admin. Grade the submission. Scenario 2: With UNOCONV converter enabled Login as admin. Go to "Site administration / Plugins / Document converters / Manage document converters" and  enable the Unoconv file converter. Logout. Login as student s2. Repeat the above steps (5 to 7). Scenario 3: With Google Drive converter enabled Login as admin. Go to "Site administration / Plugins / Document converters / Manage document converters". Enable the "Google Drive" converter and disable the Unoconv file converter. Logout. Login as student s3. Repeat the above steps in scenario 1 (5 to 7).   Expected behaviour in all the scenarios: The JPG files should be converted to PDF files. The arrow lines should point up in 4 documents.  
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
      git@github.com:tuanngocnguyen/moodle.git
    • Pull Master Branch:
      MDL-63349-Master

      Description

      As Moodle will be able to rotate submitted assignments in MDL-61537, it might be good to also automatically rotate submitted assignments.

      Consider this use case:
      A student takes a picture of a hand-written assignment document with his smartphone and submits it in Moodle instead of putting the document physically into some submission letterbox in the campus. If the smartphone orientation did not match the physical orientation of the camera sensor when taking the picture - depending on the smartphone model - the image might be stored with the physical orientation of the camera sensor and only a rotation flag within the EXIF data of the image file. This is a case which I would consider a real-life case.

      Moodle currently does not handle this rotation flag in the submitted image when processing an assignment for the assignment grading screen. With MDL-61537, a teacher will now be able to rotate the file himself within the assignment grading screen.

      However, an automatic rotation by the file's rotation flag would make even more sense.

        Attachments

        1. IMG-5055.JPG
          IMG-5055.JPG
          1.32 MB
        2. IMG-5056.JPG
          IMG-5056.JPG
          1.28 MB
        3. IMG-5057.JPG
          IMG-5057.JPG
          1.35 MB
        4. IMG-5058.JPG
          IMG-5058.JPG
          1.28 MB
        5. Screenshot_1.png
          Screenshot_1.png
          471 kB
        6. Screenshot_2.png
          Screenshot_2.png
          401 kB

          Issue Links

            Activity

              People

              Assignee:
              Nguyen Nathan Nguyen
              Reporter:
              abias Alexander Bias
              Peer reviewer:
              Matt Porritt
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 4 hours, 50 minutes
                  1d 4h 50m