Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63360

Need able to skip non-compatible files when combining convertible files to PDF in assignfeedback_editpdf

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.4.3
    • Fix Version/s: None
    • Component/s: Feedback, Files API
    • Labels:
    • Affected Branches:
      MOODLE_34_STABLE

      Description

      We found what we believe is a bug in the fileconvert plugin .

      If a students uploads two files eg. a text-file and a non-convertible file, the entire pdf-conversion will fail and no file will displayed at all. 

      Steps to reproduce: 

      1. As teacher Create an assignment - submission type "File" and number of files allowed = 2 
      2. As student upload the two attacehed files (one is a binary TI Nspire file and the other is a simple text file) in the assignet. 
      3. As a teacher open the online grader for the assignment. 

      Result: A blank page is shown in the grader view. 

       

      Expected result: The txt file should be displayed in the grader viewer. 

      We have implemented at fix, which is able to skip the non-compatible files option and combine/concatenate compatible files to "PDF".

       

       

        Attachments

        1. issue.png
          issue.png
          50 kB
        2. test.txt
          0.0 kB
        3. texas nspire file.tns
          86 kB

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                smo@praxis.dk Sam Møller
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: