Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63373

Update upgrade_stale_php_files_present() before 3.6 release

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.6
    • 3.6
    • Installation
    • MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • Hide

      web

      1. Create and install a 3.5.x site.
      2. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist:
        • /lib/classes/session/memcache.php
        • /lib/form/submitlink.php
        • /lib/medialib.php
        • /lib/eventslib.php
        • /lib/password_compat/lib/password.php
      3. Do a web based upgrade to master.
      4. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      5. Delete the touched file(s) in 2. and <<reload>>.
      6. Verify that the upgrade now proceeds ok.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      web Create and install a 3.5.x site. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist: /lib/classes/session/memcache.php /lib/form/submitlink.php /lib/medialib.php /lib/eventslib.php /lib/password_compat/lib/password.php Do a web based upgrade to master. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in 2. and <<reload>>. Verify that the upgrade now proceeds ok. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

    Description

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

      Attachments

        Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-61711 Update upgrade_stale_php_files_present() before 3.5 release

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65214 Update upgrade_stale_php_files_present() before 3.7 release

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Andrew Lyons Andrew Lyons
              David Monllaó David Monllaó
              David Monllaó David Monllaó
              Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                3/Dec/18