Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63417

Lesson: correct/incorrect class is no longer used in multichoice questions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.5, 3.5.2, 3.6, 3.7
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as Admin.
      2. Create a course.
      3. Enrol two Students in the Course.
      4. Create a Lesson activity in the Course.
      5. Add a Multichoice question in the Lesson.
        • For Answer1:
          1. Add answer and response;
          2. Set Score = 1;
        • For Answer2:
          1. Add answer and response;
          2. Set Score = 0;
      6. Log in as a Student1.
      7. Go to Course > Lesson.
      8. Answer correctly the Multichoice question.
      9. In the feedback page:
        • Inspect the response in the browser.
          1. make sure it is wrapped in a div with a class = "response correct";

      <div class="response correct">
      		 
          <em>Response</em>: <br>
      		 
          <p>Correct response</p>
      		 
      </div>

      1. Log in as a Student2.
      2. Go to Course > Lesson.
      3. Answer incorrectly the Multichoice question.
      4. In the feedback page:
        • Inspect the response in the browser.
          1. make sure it is wrapped in a div with a class = "response incorrect";

      <div class="response incorrect">
      		 
          <em>Response</em>: <br>
      		 
          <p>Incorrect response</p>
      		 
      </div>

      1. Repeat the 1-13 steps for each question type that supports responses (matching, numerical, short answer, true/false)
        1. make sure it is wrapped in a div with a class = "response incorrect";

       

      Show
      Log in as Admin. Create a course. Enrol two Students in the Course. Create a Lesson activity in the Course. Add a Multichoice question in the Lesson. For Answer1: Add answer and response; Set Score = 1; For Answer2: Add answer and response; Set Score = 0; Log in as a Student1. Go to Course > Lesson. Answer correctly the Multichoice question. In the feedback page: Inspect the response in the browser. make sure it is wrapped in a div with a class = "response correct"; <div class = "response correct" > <em>Response</em>: <br> <p>Correct response</p> </div> Log in as a Student2. Go to Course > Lesson. Answer incorrectly the Multichoice question. In the feedback page: Inspect the response in the browser. make sure it is wrapped in a div with a class = "response incorrect"; <div class = "response incorrect" > <em>Response</em>: <br> <p>Incorrect response</p> </div> Repeat the 1-13 steps for each question type that supports responses (matching, numerical, short answer, true/false) make sure it is wrapped in a div with a class = "response incorrect";  
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-63417-master
    • Pull Master Diff URL:

      Description

      I was taking a look at the changes done in MDL-43042 and MDL-61211 to apply them to the Mobile app (when offline) and I noticed that this class is no longer used.

      In the past it was applied to the response, you can see it in here.

      IMO the class should be re-applied to the HTML.

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            dpalou Dani Palou
            Peer reviewer:
            Peter Dias
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 30 minutes
                2h 30m