[MDL-63422] Fix cases of continue within switch statements - Moodle Tracker

XML

Word

Printable

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6
Fix Version/s: 3.6
Component/s: Analytics, Assignment, Blog, Chat, Choice, Competencies, Database activity module, Feedback, Forum, General, Glossary, Gradebook, Lesson, Libraries, Quiz, SCORM, Survey
Labels:
- ci

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Prepare Moodle for PHP 7.3
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-63422~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-63422
Testing Instructions:

Hide

Verify that not breakage happens via automated tests.

With PHP 7.3 it would be possible to verify that the "PHP Warning" is not shown, but that has been already verified in the Epic issue with this patch applied. So testing that everything continues working in automated tests should be enough.

Show
Verify that not breakage happens via automated tests. With PHP 7.3 it would be possible to verify that the "PHP Warning" is not shown, but that has been already verified in the Epic issue with this patch applied. So testing that everything continues working in automated tests should be enough.

Description

With PHP 7.3 a warning has been added (about an existing problem) when continue; commands are used within switch statements. Really they act as normal break; statements there and, if within a loop, we should be using continue 2; instead.

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"

Link: https://github.com/php/php-src/blob/PHP-7.3/UPGRADING
PHPUnit run: https://pastebin.com/pLcjfX3V

This is about to find all those continue uses within switch statements and replace them with the correct statement when needed.

Some links explaining continue within switch and loops:

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

continue_in_a_loop.txt
5 kB
08/Oct/18 6:06 AM
continue_in_switch_case.txt
1 kB
14/Oct/18 6:07 PM

Issue Links

has to be done before

MDL-63652 Review some break statements that maybe should be continue 2

Open

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Victor Déniz Falcón

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Dan Marsden, Eloy Lafuente (stronk7), Tim Hunt, Victor Déniz Falcón

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona), Dan Marsden, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona), Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona), Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona), Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, Tim Hunt, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Kevin Percy, Laurent David, Mathew May, Mihail Geshoski, Raquel Ortega, Sabina Abellan, Sander Bangma, Sara Arjona (@sarjona), Shamim Rezaie, Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 21/Sep/18 5:29 PM

Updated:: 03/Nov/18 6:50 AM

Resolved:: 03/Nov/18 6:50 AM

Fix Release Date:: 3/Dec/18