Details
-
Type:
Task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.6
-
Fix Version/s: 3.6
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_36_STABLE
-
Fixed Branches:MOODLE_36_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
With PHP 7.3 a warning has been added (about an existing problem) when continue; commands are used within switch statements. Really they act as normal break; statements there and, if within a loop, we should be using continue 2; instead.
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"
Link: https://github.com/php/php-src/blob/PHP-7.3/UPGRADING
PHPUnit run: https://pastebin.com/pLcjfX3V
This is about to find all those continue uses within switch statements and replace them with the correct statement when needed.
Some links explaining continue within switch and loops:
Attachments
Issue Links
- has to be done before
-
MDL-63652 Review some break statements that maybe should be continue 2
-
- Open
-