Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63431

Atto media plugin: add title global attribute support

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Ensure you have a small video (mp4) and audio clip (you can use the same clip)
      2. Create a course with a forum in it
      3. Navigate to this forum and add a new post

      Note: The following tests follow on from one another

      Video

      Video: Regression test
      1. Open HTML editor
      2. Click on "Insert Media" button
      3. Select "Video" tab
      4. Upload your video clip
      5. Click "Insert Media" button
      6. Click the "Show more buttons" link in the Atto toolbar (first icon)
      7. Click </> button to view the HTML source
        1. Observe that "title" attribute is not present in <video> tag.
      8. Toggle the "HTML source" button again to return to the normal editor
      Video: Edit existing video
      1. Select the player in the editor and click "Insert Media" button again
      2. Observe the "Video" tab is selected and source URL present
      3. Click on "Display options" sub-menu
        1. Confirm that the Title is empty
      4. Set a title
      5. Click "Insert Media" button
      6. Click </> button to view the HTML source
        1. Observe that "title" attribute in <video> tag is now set to the value you specified
      7. Toggle the "HTML source" button again to return to the normal editor
      Video: Edit existing video with title
      1. Select the player in the editor and click "Insert Media" button again
      2. Observe the "Video" tab is selected and source URL present
      3. Click on "Display options" sub-menu
        1. Confirm that the Title is set to the value you set in the previous test
      4. Change the title
      5. Click "Insert Media" button
      6. Click </> button to view the HTML source
        1. Observe that "title" attribute in <video> tag is now set to the updated value
      7. Toggle the "HTML source" button again to return to the normal editor
      Video: Remove title from existing value
      1. Select the player in the editor and click "Insert Media" button again
      2. Observe the "Video" tab is selected and source URL present
      3. Click on "Display options" sub-menu
        1. Confirm that the Title is set to the value you set in the previous test
      4. Unset the value
      5. Click "Insert Media" button
      6. Click </> button to view the HTML source
        1. Observe that "title" attribute in <video> tag is not present
      7. Toggle the "HTML source" button again to return to the normal editor
      Video: Rendered content
      1. Add a second video:
        1. Set the title to something you will remember
          Note: You will now have two videos on the page - the first from the previous test without any title, and this second one with a title
      2. Post the forum post
      3. View the forum post
      4. Inspect each of the two videos:
        1. Confirm that the video without a title has a default title of the filename
          i.e. If your video file was called 'bananas.mp4', this name will be tht title
        2. Confirm that the second video (with a title) has the title you specified

      Testing audio title

      Repeat steps for video title testing, but choose "Audio" tab in "Insert Media" interface. You can use the same mp4 video source for audio

      Show
      Setup Ensure you have a small video (mp4) and audio clip (you can use the same clip) Create a course with a forum in it Navigate to this forum and add a new post Note: The following tests follow on from one another Video Video: Regression test Open HTML editor Click on "Insert Media" button Select "Video" tab Upload your video clip Click "Insert Media" button Click the "Show more buttons" link in the Atto toolbar (first icon) Click </> button to view the HTML source Observe that "title" attribute is not present in <video> tag. Toggle the "HTML source" button again to return to the normal editor Video: Edit existing video Select the player in the editor and click "Insert Media" button again Observe the "Video" tab is selected and source URL present Click on "Display options" sub-menu Confirm that the Title is empty Set a title Click "Insert Media" button Click </> button to view the HTML source Observe that "title" attribute   in <video> tag is now set to the value you specified Toggle the "HTML source" button again to return to the normal editor Video: Edit existing video with title Select the player in the editor and click "Insert Media" button again Observe the "Video" tab is selected and source URL present Click on "Display options" sub-menu Confirm that the Title is set to the value you set in the previous test Change the title Click "Insert Media" button Click </> button to view the HTML source Observe that "title" attribute   in <video> tag is now set to the updated value Toggle the "HTML source" button again to return to the normal editor Video: Remove title from existing value Select the player in the editor and click "Insert Media" button again Observe the "Video" tab is selected and source URL present Click on "Display options" sub-menu Confirm that the Title is set to the value you set in the previous test Unset the value Click "Insert Media" button Click </> button to view the HTML source Observe that "title" attribute in <video> tag   is not present Toggle the "HTML source" button again to return to the normal editor Video: Rendered content Add a second video: Set the title to something you will remember Note: You will now have two videos on the page - the first from the previous test without any title, and this second one with a title Post the forum post View the forum post Inspect each of the two videos: Confirm that the video without a title has a default title of the filename i.e. If your video file was called 'bananas.mp4', this name will be tht title Confirm that the second video (with a title) has the title you specified Testing audio title Repeat steps for video title testing, but choose "Audio" tab in "Insert Media" interface. You can use the same mp4 video source for audio
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-63431-master

      Description

      When a <video> or <audio> tag is parsed by the filter_mediaplugin for player embedding, it uses a default title attribute from the filename (e.g. foo.mp4). This is taken from the $name parameter to player plugin.

      It would be useful for atto_media to allow the author to enter a more meaningful title attribute for the video/audio file.
      The only workaround to this is to manually edit the HTML source.

        Attachments

        1. 1.PNG
          1.PNG
          403 kB
        2. 2.PNG
          2.PNG
          204 kB
        3. 3.PNG
          3.PNG
          172 kB
        4. MDL-63431-audio.png
          MDL-63431-audio.png
          68 kB
        5. MDL-63431-video.png
          MDL-63431-video.png
          67 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m