Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63442

Don't show note about MOODLEID cookie if $CFG->rememberusername is set to no

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Remember username = Yes
      1. Login as admin
      2. Go to "Site administration > Security > Site security settings"
      3. Set "Remember username" to "Yes"
      4. Logout
      5. Go to the login page
      6. Click on the help icon near the "Cookies must be enabled note"
      7. The help text will start with "Two cookies are used by this site [...]"
      Remember username = Optional
      1. Login as admin
      2. Go to "Site administration > Security > Site security settings"
      3. Set "Remember username" to "Optional"
      4. Logout
      5. Go to the login page
      6. Click on the help icon near the "Cookies must be enabled note"
      7. The help text will start with "Two cookies are used by this site [...]"
      Remember username = No
      1. Login as admin
      2. Go to "Site administration > Security > Site security settings"
      3. Set "Remember username" to "No"
      4. Logout
      5. Go to the login page
      6. Click on the help icon near the "Cookies must be enabled note"
      7. The help text will start with "This site uses one session cookie [...]"
      Show
      Remember username = Yes Login as admin Go to "Site administration > Security > Site security settings" Set "Remember username" to " Yes " Logout Go to the login page Click on the help icon near the "Cookies must be enabled note" The help text will start with "Two cookies are used by this site [...] " Remember username = Optional Login as admin Go to "Site administration > Security > Site security settings" Set "Remember username" to " Optional " Logout Go to the login page Click on the help icon near the "Cookies must be enabled note" The help text will start with "Two cookies are used by this site [...] " Remember username = No Login as admin Go to "Site administration > Security > Site security settings" Set "Remember username" to " No " Logout Go to the login page Click on the help icon near the "Cookies must be enabled note" The help text will start with "This site uses one session cookie [...] "
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63442-master

      Description

      On the login page, there is a help icon after the "Cookies must be enabled in your browser" note.

      This help icon says:

      Two cookies are used by this site:

      The essential one is the session cookie, usually called MoodleSession. You must allow this cookie into your browser to provide continuity and maintain your login from page to page. When you log out or close the browser this cookie is destroyed (in your browser and on the server).

      The other cookie is purely for convenience, usually called something like MOODLEID. It just remembers your username within the browser. This means when you return to this site the username field on the login page will be already filled out for you. It is safe to refuse this cookie - you will just have to retype your username every time you log in.

      Unfortunately, if $CFG->rememberusername is set to no, the second paragraph is obsolete and only creates confusion.

      The logic behind the help icon's content should evaluate the $CFG->rememberusername setting and
      1. add the second paragraph only if it is set to yes.
      2. skip the second paragraph if it is set to no.
      3. add a modified version of the second paragraph (which tells the user that this cookie is only set if he checks the "Remember username" checkbox) if it is set to optional.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                abias Alexander Bias
                Reporter:
                abias Alexander Bias
                Peer reviewer:
                David Mudrák (@mudrd8mz)
                Integrator:
                Jun Pataleta
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, cameron1729, David Mudrák (@mudrd8mz), Helen Foster
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 20 minutes
                  20m