[MDL-63528] "Remember username" checkbox always being rendered regardless of the $CFG->rememberusername setting - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.5, 3.5.2
Fix Version/s: 3.4.6, 3.5.3
Component/s: Authentication
Labels:
- ci
- triaged

Testing Instructions:

Hide

Tests are already covered by Behat.

Show
Tests are already covered by Behat.
Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull 3.5 Branch:
~~MDL-63528~~-35
Pull 3.5 Diff URL:
https://github.com/junpataleta/moodle/compare/5211af1658...MDL-63528-35
Pull Master Branch:
~~MDL-63528~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/3e24741d0a...MDL-63528-master

Description

To reproduce:

Log in as an admin
Go to "Site administration > Security > Site security settings"
Set "Remember username" to No
Log out (or open an incognito browser window)
Go to the login page.
Expected: The "Remember username" checkbox shouldn't be rendered.
Actual: The "Remember username" checkbox is still being rendered.

Attachments

Issue Links

Discovered while testing

MDL-63442 Don't show note about MOODLEID cookie if $CFG->rememberusername is set to no

Closed

Activity

People

Assignee:

Jun Pataleta

Reporter:

Jun Pataleta

Peer reviewer:

Daniel Neis Araujo

Integrator:

David Monllaó

Tester:

CiBoT

Participants:

CiBoT, Daniel Neis Araujo, David Monllaó, Jun Pataleta

Component watchers:

Jake Dallimore, Jun Pataleta

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

04/Oct/18 11:13 AM

Updated:

31/Oct/18 7:12 AM

Resolved:

31/Oct/18 7:12 AM

Fix Release Date:

12/Nov/18