[MDL-63607] Remove theme from behat config whitelist - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.8, 3.4.5, 3.5.2, 3.6
Fix Version/s: 3.5.5, 3.6.3
Component/s: Automated functional tests (behat)
Labels:
- ci
- triaged

Testing Instructions:
Hide

Initialise Behat

php admin/tool/behat/cli/init.php -o

Open config.php and add:

$CFG->theme = 'clean';

Kick off a standard behat run without specifying theme for admin/tool/policy/tests/behat/acceptances.feature: e.g.

php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on"

Confirm that the theme used is Boost

Confirm everything passes

Reinitialise Behat to include other themes

php admin/tool/behat/cli/init.php -o -a

Open config.php and change theme to boost:

$CFG->theme = 'boost';

Kick off a standard behat run specifying the suite as clean for admin/tool/policy/tests/behat/acceptances.feature: e.g.

php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" --suite=clean

Confirm that the theme used is Clean

Confirm everything passes
Show
Initialise Behat php admin/tool/behat/cli/init.php -o Open config.php and add: $CFG->theme = 'clean'; Kick off a standard behat run without specifying theme for admin/tool/policy/tests/behat/acceptances.feature : e.g. php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" Confirm that the theme used is Boost Confirm everything passes Reinitialise Behat to include other themes php admin/tool/behat/cli/init.php -o -a Open config.php and change theme to boost: $CFG->theme = 'boost'; Kick off a standard behat run specifying the suite as clean for admin/tool/policy/tests/behat/acceptances.feature : e.g. php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" --suite=clean Confirm that the theme used is Clean Confirm everything passes
Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.5 Branch:
~~MDL-63607~~-35
Pull 3.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/5211af1658...MDL-63607-35
Pull Master Branch:
~~MDL-63607~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/33a388eff7...MDL-63607-master

Description

I think that we should remove theme from the behat config whitelist (behat_clean_init_config).

If the theme var is set, this does not affect the suite that is actually run, and if the two differ then the wrong features may be run causing failures.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-63607.jpg
69 kB
16/Jan/19 2:07 PM

Activity

People

Assignee:: Andrew Nicols

Reporter:: Andrew Nicols

Peer reviewer:: Simey Lameze

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Andrew Nicols, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Marina Glancy, Simey Lameze

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 10/Oct/18 12:05 PM

Updated:: 04/Feb/19 6:21 PM

Resolved:: 18/Jan/19 1:24 AM

Fix Release Date:: 11/Mar/19

Time Tracking

Estimated:

Remaining:

Logged: