Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63607

Remove theme from behat config whitelist

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Initialise Behat

        php admin/tool/behat/cli/init.php -o
        

      2. Open config.php and add:

        $CFG->theme = 'clean';
        

      3. Kick off a standard behat run without specifying theme for admin/tool/policy/tests/behat/acceptances.feature: e.g.

        php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on"
        

        1. Confirm that the theme used is Boost
        2. Confirm everything passes
      4. Reinitialise Behat to include other themes

        php admin/tool/behat/cli/init.php -o -a
        

      5. Open config.php and change theme to boost:

        $CFG->theme = 'boost';
        

      6. Kick off a standard behat run specifying the suite as clean for admin/tool/policy/tests/behat/acceptances.feature: e.g.

        php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" --suite=clean
        

        1. Confirm that the theme used is Clean
        2. Confirm everything passes
      Show
      Initialise Behat php admin/tool/behat/cli/init.php -o Open config.php and add: $CFG->theme = 'clean'; Kick off a standard behat run without specifying theme for admin/tool/policy/tests/behat/acceptances.feature : e.g. php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" Confirm that the theme used is Boost Confirm everything passes Reinitialise Behat to include other themes php admin/tool/behat/cli/init.php -o -a Open config.php and change theme to boost: $CFG->theme = 'boost'; Kick off a standard behat run specifying the suite as clean for admin/tool/policy/tests/behat/acceptances.feature : e.g. php admin/tool/behat/cli/run.php --name="Agree on behalf of another user as a manager, single policy, javascript on" --suite=clean Confirm that the theme used is Clean Confirm everything passes
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-63607-master

      Description

      I think that we should remove theme from the behat config whitelist (behat_clean_init_config).

      If the theme var is set, this does not affect the suite that is actually run, and if the two differ then the wrong features may be run causing failures.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h