Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63614

Activity completion - require passing grade or all attempts completed not working as expected

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Covered by behat test.

      If needed, for manual testing, on a site with badges enabled:

      1. Create a quiz, with a single true/false question
      2. Configure the quiz to allow 2 attempts and set the passing grade to 75
      3. Enable activity completion for the quiz, and set the following: require grade, require passing grade, or all attempts completed
      4. Create a badge using the quiz as the sole criteria
      5. Enable the badge
      6. Attempt the quiz twice by the student, failing the quiz both times
      7. Verify that the activity completion checkbox for the student is marked complete

      Verify that the student was awarded the badge

      Show
      Covered by behat test. If needed, for manual testing, on a site with badges enabled: Create a quiz, with a single true/false question Configure the quiz to allow 2 attempts and set the passing grade to 75 Enable activity completion for the quiz, and set the following: require grade, require passing grade, or all attempts completed Create a badge using the quiz as the sole criteria Enable the badge Attempt the quiz twice by the student, failing the quiz both times Verify that the activity completion checkbox for the student is marked complete Verify that the student was awarded the badge
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
      MDL-63614_M35v1
    • Pull 3.6 Branch:
      MDL-63614_M36v1
    • Pull Master Branch:
      MDL-63614_M37v1

      Description

      If you set up a quiz to "require a passing grade or have all attempts completed" and use that quiz as the sole criteria for a badge.  It is impossible for a student who fails the quiz (but completes all allowed attempts) to earn the badge.

      Steps to reproduce: (reproducable on qa.moodle.net)

      on a site with badges enabled:

      1. create a quiz, with a single true/false question.
      2. Configure the quiz to allow 2 attempts and set the passing grade to 75
      3. Enable activity completion for the quiz, and set the following: require grade, require passing grade, or all attempts completed
      4. create a badge using the quiz as the sole criteria
      5. enable the badge
      6. Attempt the quiz twice by the student, failing the quiz both times.
      7. Verify that the activity completion checkbox for the student is marked complete

      Expected result: student should have been awarded the badge
      Actual result: the badge is not awarded.

       

        Attachments

          Activity

            People

            • Assignee:
              sbourget Stephen Bourget
              Reporter:
              sbourget Stephen Bourget
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Yuliya Bozhko, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19