Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6363

typo in mod/forum/restorelib.php prevents grouped discussions from being accessible to group after a restore.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3, 1.6.1
    • Fix Version/s: 1.6.4, 1.7, 1.8
    • Component/s: Forum
    • Labels:
      None
    • Environment:
      All. This is a PHP typo!
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_15_STABLE, MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

      Description

      see mod/forum/restorelib.php line 219 ish. You should see this...

      $group = backup_getid($restore->backup_unique_code,"group",$discussion->groupid);

      ...it should be this...

      $group = backup_getid($restore->backup_unique_code,"groups",$discussion->groupid);

      ...note: groupS instead of group!

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            vyshane Vy-Shane Sin Fat added a comment -

            Fixed.

            Show
            vyshane Vy-Shane Sin Fat added a comment - Fixed.
            Hide
            koen Koen Roggemans added a comment -

            The same typo is in mod/chat/restorelib.php and in mod/wiki/restorelib.php
            For wiki it definitely causes problems (see http://moodle.org/mod/forum/discuss.php?d=52408#256734), for chat not confirmed

            Show
            koen Koen Roggemans added a comment - The same typo is in mod/chat/restorelib.php and in mod/wiki/restorelib.php For wiki it definitely causes problems (see http://moodle.org/mod/forum/discuss.php?d=52408#256734 ), for chat not confirmed
            Hide
            vyshane Vy-Shane Sin Fat added a comment -

            Thanks. I've checked in fixes to the 1.6, 1.7 and 1.8 branches.

            Show
            vyshane Vy-Shane Sin Fat added a comment - Thanks. I've checked in fixes to the 1.6, 1.7 and 1.8 branches.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  7/Nov/06