Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63670

Message unit tests cause duplicate tests

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 3.4.5, 3.5.2, 3.6
    • None
    • Messages

    Description

      message/tests/api_test.php and message/tests/events_test.php both extend core_message_messagelib_testcase which also has its own tests.
      As a result, those tests are incorporated into all three files and are run three times.

      Additionally these tests contain a setUp which run resetAfterTest() which means that it is not possible to write tests which do not need a reset.

      Attachments

        Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDLSITE-5960 Ban use of resetAfterTest in shared setup

          • Low - Cosmetic problems, nice-to-have features
          • Open
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-65093 Users should be informed that they can't block a user who has permission to message all users

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              dobedobedoh Andrew Lyons
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: