Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63707

Undefined variable in combined_document::refresh_files()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.2
    • Fix Version/s: None
    • Component/s: Assignment, Files API
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE

      Description

      Looking at the code for \assignfeedback_editpdf\combined_document, I'm seeing this line in refresh_files().

      $converter->poll_conversion($conversion);

      The $conversion variable is not defined so this is probably not doing what it's expected to. I don't see any conversion plugins that do anything in poll_conversion() but, if they did, I suspect they'd probably break if passed a null. Should it be $file instead of $conversion?

      https://github.com/moodle/moodle/blob/master/mod/assign/feedback/editpdf/classes/combined_document.php#L193

      (I should note, this is not affecting me in any way and I don't know how to "reproduce" an error - just reporting it as I noticed it while looking at something else!)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              maherne Michael Aherne
              Participants:
              Component watchers:
              Damyon Wiese, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: