Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63717

Moodle app returning 'Coding error' when external themes set invalid URLs

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. For testing this issue you need access to the Moodle database (via phpMyAdmin, console or another frontend)
      2. In the config_plugins table, create or update (if already exists) the following record: Field 'plugin' = 'core_admin' and field 'name' = 'logo'
      3. Set this new 'value': http://localhost/m/stable_master/pluginfile.php/1/core_admin/logo/0x200/-1/Airbus%20AS355F1%20Twin%20Squirrel%20Helicopter%20with%20Buachaille%20Etive%20M%C3%B2r.jpg
      4. Execute the following curl request in a terminal:

        curl 'http://localhost/m/stable_master/lib/ajax/service.php' --data-binary '[{"index":0,"methodname":"tool_mobile_get_public_config","args":{}}]' | python -m "json.tool"

      5. Check that in the response, the logourl field is set to empty, just ""
      Show
      For testing this issue you need access to the Moodle database (via phpMyAdmin, console or another frontend) In the config_plugins table, create or update (if already exists) the following record: Field 'plugin' = 'core_admin' and field 'name' = 'logo' Set this new 'value': http://localhost/m/stable_master/pluginfile.php/1/core_admin/logo/0x200/-1/Airbus%20AS355F1%20Twin%20Squirrel%20Helicopter%20with%20Buachaille%20Etive%20M%C3%B2r.jpg Execute the following curl request in a terminal: curl 'http://localhost/m/stable_master/lib/ajax/service.php' --data-binary ' [{"index":0,"methodname":"tool_mobile_get_public_config","args":{}}] ' | python -m "json.tool" Check that in the response, the logourl field is set to empty, just ""
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63717-master

      Description

      When connecting to an https site that has 'Aardvark' as the default theme the Moodle app fails to display the login screen but instead returns the coding error "invalid json in request: Syntax error".  Works correctly with the 'More' theme.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              pwelham Peter Welham
              Peer reviewer:
              Albert Gasset
              Integrator:
              Damyon Wiese
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18