Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63722

Question bank window closes when trying to paginate

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is covered by behat.

      For manual testing:

      1. Create a course
      2. Go to the course's question bank and add more than 20 (for example 22) questions from any type (true/false questions might be faster to create). Make a note of the question category you are creating the questions in.
      3. Create a quiz in the course
      4. Go to the question editing page of the quiz
      5. Click on the "add" ink and then select "from question bank".
      6. Select the category you had put the questions in (from step 2)
      7. Verify that the list of questions is paginated.
      8. Click on page 2 link
      9. Verify that the list of questions is updated and now shows questions from the second page
      10. Click somewhere outside of the modal (on the grey area)
      11. Verify that the modal is closed
      Show
      This is covered by behat. For manual testing: Create a course Go to the course's question bank and add more than 20 (for example 22) questions from any type (true/false questions might be faster to create). Make a note of the question category you are creating the questions in. Create a quiz in the course Go to the question editing page of the quiz Click on the "add" ink and then select "from question bank". Select the category you had put the questions in (from step 2) Verify that the list of questions is paginated. Click on page 2 link Verify that the list of questions is updated and now shows questions from the second page Click somewhere outside of the modal (on the grey area) Verify that the modal is closed
    • Workaround:
      Hide

      Commenting this line in /lib/amd/src/modal.js

      Comenting these three lines in /lib/amd/src/modal.js:

      //if (!$(e.target).closest(SELECTORS.MODAL).length) { 

      //    this.hide();

      //}

       

       

      Show
      Commenting this line in /lib/amd/src/modal.js Comenting these three lines in /lib/amd/src/modal.js: //if (!$(e.target).closest(SELECTORS.MODAL).length) {   //    this.hide(); // }    
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-63722-master

      Description

      When adding a question to a quiz from the question bank, if category has enough questions to paginate the browse window closes when trying to click next page and other links.

       

      Tested on 3.6dev+ (Build: 20181019)

        Attachments

        1. MDL-63722.jpg
          MDL-63722.jpg
          16 kB
        2. MDL-63722_Step11.mp4
          325 kB
        3. bug.png
          bug.png
          209 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m