Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63746

MDL-62139 followup - 34 cog icon focus not highlighted

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As a teacher

      Go to the dashboard page

      Turn editing on

      1. Verify that the "cog" link that opens the a menu at the top right of each block can be focused with the tab key. 

      2. Verify that when the cog link are focused, they have an outline.

      3. Verify that the cog icons are vertically inline with the "move icons" for each block.

       

      Show
      As a teacher Go to the dashboard page Turn editing on 1. Verify that the "cog" link that opens the a menu at the top right of each block can be focused with the tab key.  2. Verify that when the cog link are focused, they have an outline. 3. Verify that the cog icons are vertically inline with the "move icons" for each block.  
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63746-master

      Description

      This is a followup created after MDL-62139 integration. As reported by Anna Carissa Sadia the cog icon gets the focus, but the DOM node is not highlighted. I could reproduce the issue in 34 and I notice that the highlighting style the cog gets differs from other DOM nodes with docus in master.

        Attachments

        1. tab_navigated_outlined.png
          tab_navigated_outlined.png
          23 kB
        2. too_much_separation.png
          too_much_separation.png
          7 kB
        3. user_menu_34.png
          user_menu_34.png
          28 kB
        4. user_menu_master.png
          user_menu_master.png
          23 kB

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              David Monllaó
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18