Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63746

MDL-62139 followup - 34 cog icon focus not highlighted

    XMLWordPrintable

Details

    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-63746-master
    • Hide

      As a teacher

      Go to the dashboard page

      Turn editing on

      1. Verify that the "cog" link that opens the a menu at the top right of each block can be focused with the tab key. 

      2. Verify that when the cog link are focused, they have an outline.

      3. Verify that the cog icons are vertically inline with the "move icons" for each block.

       

      Show
      As a teacher Go to the dashboard page Turn editing on 1. Verify that the "cog" link that opens the a menu at the top right of each block can be focused with the tab key.  2. Verify that when the cog link are focused, they have an outline. 3. Verify that the cog icons are vertically inline with the "move icons" for each block.  

    Description

      This is a followup created after MDL-62139 integration. As reported by Anna Sadia the cog icon gets the focus, but the DOM node is not highlighted. I could reproduce the issue in 34 and I notice that the highlighting style the cog gets differs from other DOM nodes with docus in master.

      Attachments

        1. tab_navigated_outlined.png
          23 kB
          Eloy Lafuente (stronk7)
        2. too_much_separation.png
          7 kB
          Eloy Lafuente (stronk7)
        3. user_menu_34.png
          28 kB
          Eloy Lafuente (stronk7)
        4. user_menu_master.png
          23 kB
          Eloy Lafuente (stronk7)

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62139 Boost: Gear icon does not function as an accessible menu

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-63840 Drop down cog in clean looks like a miniature.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-63747 MDL-62139 followup - Action menus styling issues

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              damyon Damyon Wiese
              dmonllao David Monllaó
              David Monllaó David Monllaó
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Jun Pataleta, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/18