Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 3.4.5, 3.5.2, 3.6
Component/s: Themes
Labels:
- ci
- patch

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/lucaboesch/moodle.git
Pull 4.4 Branch:
MDL-63802-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...lucaboesch:MDL-63802-404
Pull 4.5 Branch:
MDL-63802-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...lucaboesch:MDL-63802-405
Pull Main Branch:
MDL-63802-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...lucaboesch:MDL-63802-main
Testing Instructions:
Hide

Test in Classic.

Insert a quiz to your course, set "Extra restrictions on attempts" → "Show more…" → "Browser security" to "Full screen pop-up with some JavaScript security".

Attempt the quiz.

Verify the nav element has the correct ARIA tag.
Show
Test in Classic. Insert a quiz to your course, set "Extra restrictions on attempts" → "Show more…" → "Browser security" to "Full screen pop-up with some JavaScript security". Attempt the quiz. Verify the nav element has the correct ARIA tag.
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-63802 using repository: https://github.com/lucaboesch/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-63802-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-63802-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-63802-main | CI Job]

_{More information about this report}

Built on: Thu 21 Nov 2024 12:48:24 PM UTC
Show
Code verified against automated checks. Checked MDL-63802 using repository: https://github.com/lucaboesch/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-63802-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-63802-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-63802-main | CI Job ] More information about this report Built on: Thu 21 Nov 2024 12:48:24 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-63802-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17479/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59551/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59552/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-63802-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17480/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59553/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59554/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-63802-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17481/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59555/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59556/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59557/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59558/ App tests (stable app version)

Built on: Thu Nov 21 02:25:23 PM UTC 2024
Show
Launching automatic jobs for branch MDL-63802 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17479/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59551/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59552/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-63802 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17480/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59553/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59554/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-63802 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17481/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59555/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59556/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59557/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59558/ App tests (stable app version) Built on: Thu Nov 21 02:25:23 PM UTC 2024

In ~~MDL-62145~~ the file navbar.mustache had the following ' aria-label="#str}}sitemenubar, admin{{/str"' appended to the 'nav' tag, being https://github.com/damyon/moodle/commit/805f078b1911b05f12325e3d40253ab14d233627#diff-62707c82a868265f76f37152c348e222R20. But there is also the file 'navbar-secure.mustache'. Surely that needs the change for accessibility too?

is a regression caused by

MDL-62145 Boost: Invisible content is being announced to screen readers

Closed

Assignee:: Luca Bösch

Reporter:: Gareth J Barnard

Peer reviewer:: Stefan Hanauska

Participants:: Brett Dalton, Gareth J Barnard, Jun Pataleta, Luca Bösch, Stefan Hanauska

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 29/Oct/18 8:00 PM

Updated:: 22/Nov/24 12:29 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify