Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63813

Recent behat failures related to timeline block

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Dashboard (My home)
    • Labels:

      Description

      Since some days ago (and in the middle of other hundred of failures), we are getting this, with clean (master only):

      Link: https://ci.moodle.org/job/W.05.01%20-%20Behat%20-%20Chrome%20+%20Postgres%20+%20Clean/227/

      And, performing a bisect run with --suite clean --name 'Persistent All in date view'

      9e95193e9fd0ac9a69ce6c7573c97017e6565034 is the first bad commit
      commit 9e95193e9fd0ac9a69ce6c7573c97017e6565034
      Author: Peter <peter@moodle.com>
      Date:   Thu Oct 4 15:57:04 2018 +0800
       
          MDL-63352 block_timeline: Persist user preference on timeline
          
          * Persist sort preference to the user table
          * Persist filter preferences to the user table
          * Add behat tests to test persistence
          * Add the gdpr exports for the user preferences as well as unit tests for the same
          * Updated view_nav.min
       
      :040000 040000 71ab7603c7c4ddaa920a24fd6cee63af4c6914bb f7f20a7bd82e82b6a8639cdf134bcc697f683a1c M	blocks
      :040000 040000 a5d11fcb5b5eb3e49053d1c17ff07e4dd2e53c28 ca0b0041da369a218a02ebc4dd3258a72d9973a4 M	theme
      

      So this seems to be a regression in clean caused by MDL-63352.

      Worth trying to get it passing (fixing the code or the test). Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Ryan Wyllie
                Integrator:
                Jun Pataleta
                Tester:
                CiBoT
                Participants:
                Component watchers:
                Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18