[MDL-63817] Add page limit persistence to timeline block - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5, 3.6
Fix Version/s: 3.6
Component/s: Blocks
Labels:
- ci
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Improvements to the Dashboard and Course Overview page
Pull from Repository:
git://github.com/peterRd/moodle.git
Pull Main Branch:
~~MDL-63817~~-master
Pull Main Diff URL:
https://github.com/peterRd/moodle/compare/MDL-63817-master~...MDL-63817-master
Testing Instructions:
Hide

PHPUnit tests provided
Prerequisites:

(single/multiple) courses with atleast 10 activities in total with due dates in the future

Have the Timeline block in the dashboard

Manual instructions (Test with Boost and clean):

Login as any user

Set sort to 'sort by dates' option

Select the filter "All" from the dropdown

Toggle the page limit

Confirm additional activities show up

Reload page

Limit should persist and be automatically selected (and match selected value in 4)

The number of assignments displayed should match upto the limit specified( in 4)
Show
PHPUnit tests provided Prerequisites: (single/multiple) courses with atleast 10 activities in total with due dates in the future Have the Timeline block in the dashboard Manual instructions (Test with Boost and clean): Login as any user Set sort to 'sort by dates' option Select the filter "All" from the dropdown Toggle the page limit Confirm additional activities show up Reload page Limit should persist and be automatically selected (and match selected value in 4) The number of assignments displayed should match upto the limit specified( in 4)

Description

The blocks should remember the "per page" option the user has selected in their paged content widgets so that when the page is reloaded the same number of items is rendered again rather than being reset to the default value.

E.g. the timeline block has options to view 5,10,25 courses per page but it doesn't remember which option the user selected and will default back to 5 on each page load.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-63817.PNG
57 kB
20/Nov/18 1:03 PM

Issue Links

caused a regression

MDL-64425 Timeline block showing a JS error in the console

Closed

is blocked by

MDL-63793 Course overview block should remember number of courses per page

Closed

Activity

People

Assignee:: Peter Dias

Reporter:: Peter Dias

Peer reviewer:: Simey Lameze

Integrator:: David Monllaó

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Jun Pataleta, Peter Dias, Przemek Kaszubski, Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 30/Oct/18 2:03 PM

Updated:: 19/Dec/18 4:54 AM

Resolved:: 20/Nov/18 11:25 PM

Fix Release Date:: 3/Dec/18

Time Tracking

Estimated:

Remaining:

Logged:

20m