Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63820

Assignment comments feedback plugin does not implement get_file_areas

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. As admin, create a course.
      2. Create and an assignment activity with feedback comments enabled.
      3. Enrol one user as student in the course
      4. Enrol one user as teacher in the course
      5. As the student, submit the assignment.
      6. As the teacher, grade the student submission and embed an new image in the feedback editor.
      7. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      8. Create a Token in the mobile app service for the student user in Site administration ► Plugins ► Web services ► Manage tokens
      9. Open the console an execute this curl request, replacing wstoken with the token you just created for the user and the site url with yours. Replace the assignid with the instance id of the assignment:
        curl 'http://YOUR_MOODLE_URL/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=mod_assign_get_submission_status&wstoken=STUDENT_TOKEN&assignid=ASSIGNMENT_ID' | python -m "json.tool"
      10. Check that the list of feedback plugins in the JSON output contains a plugin with a filearea named "feedback" and the embedded file.
      Show
      As admin, create a course. Create and an assignment activity with feedback comments enabled. Enrol one user as student in the course Enrol one user as teacher in the course As the student, submit the assignment. As the teacher, grade the student submission and embed an new image in the feedback editor. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a Token in the mobile app service for the student user in Site administration ► Plugins ► Web services ► Manage tokens Open the console an execute this curl request, replacing wstoken with the token you just created for the user and the site url with yours. Replace the assignid with the instance id of the assignment: curl 'http://YOUR_MOODLE_URL/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=mod_assign_get_submission_status&wstoken=STUDENT_TOKEN&assignid=ASSIGNMENT_ID' | python -m "json.tool" Check that the list of feedback plugins in the JSON output contains a plugin with a filearea named "feedback" and the embedded file.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:

      Description

      In MDL-27520 support for embedding files in feedback comments was implemented. In order to support the same feature in the mobile app the web service should return the list of files of the feedback. But it does not return the files for feedback comments because the "get_file_area" method is not implemented in this feedback plugin,

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 23 minutes
                  23m