Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63826

Oracle unit test failures @ assignsubmission_comments_privacy_testcase

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.4.5, 3.5.2, 3.6
    • 3.4.6, 3.5.3
    • Assignment, Privacy
    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • Hide

      CiBoT: Get unit tests passing for all DBs (specifically Oracle). The reported failure @ assignsubmission_comments_privacy_testcase::test_get_userids_from_context should be gone.

      Show
      CiBoT: Get unit tests passing for all DBs (specifically Oracle). The reported failure @ assignsubmission_comments_privacy_testcase::test_get_userids_from_context should be gone.

    Description

      This is a followup of MDL-63531 that, apparently introduced a problem within Oracle (34, 35 & master).

      Link: https://ci.moodle.org/job/W.01.05%20-%20PHPUnit%20-%20Oracle/118/

      And a bisect session has pointed to that issue as responsible of the failures:

      $ git bisect bad
      b96e7fa6b23e888e03fb2ef665706f8468676061 is the first bad commit
      commit b96e7fa6b23e888e03fb2ef665706f8468676061
      Author: Adrian Greeve <abgreeve@gmail.com>
      Date:   Wed Oct 10 13:27:23 2018 +0800
       
          MDL-63531 mod_assign: Update mod assign to use new interface.
          
          This introduces a new interface for assign sub-plugins and
          updates the mod_assign provider to implement the new general
          interface for deleting data for users in a context.
       
      :040000 040000 354589206727f401e4540c7a1fd7a3d5f252e887 a055133905c42d79153cca5fffe45b5121f4f828 M	mod
      

      To reproduce, just run:

      vendor/bin/phpunit "assignsubmission_comments_privacy_testcase" mod/assign/submission/comments/tests/privacy_test.php

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Andrew Lyons Andrew Lyons
              Jun Pataleta Jun Pataleta
              CiBoT CiBoT
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/18