Loading...

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-63826~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/8aae5e1...MDL-63826
Testing Instructions:

Hide

CiBoT: Get unit tests passing for all DBs (specifically Oracle). The reported failure @ assignsubmission_comments_privacy_testcase::test_get_userids_from_context should be gone.

Show
CiBoT: Get unit tests passing for all DBs (specifically Oracle). The reported failure @ assignsubmission_comments_privacy_testcase::test_get_userids_from_context should be gone.

This is a followup of ~~MDL-63531~~ that, apparently introduced a problem within Oracle (34, 35 & master).

And a bisect session has pointed to that issue as responsible of the failures:

$ git bisect bad

b96e7fa6b23e888e03fb2ef665706f8468676061 is the first bad commit

commit b96e7fa6b23e888e03fb2ef665706f8468676061

Author: Adrian Greeve <abgreeve@gmail.com>

Date:   Wed Oct 10 13:27:23 2018 +0800

    MDL-63531 mod_assign: Update mod assign to use new interface.

    This introduces a new interface for assign sub-plugins and

    updates the mod_assign provider to implement the new general

    interface for deleting data for users in a context.

:040000 040000 354589206727f401e4540c7a1fd7a3d5f252e887 a055133905c42d79153cca5fffe45b5121f4f828 M	mod

To reproduce, just run:

vendor/bin/phpunit "assignsubmission_comments_privacy_testcase" mod/assign/submission/comments/tests/privacy_test.php

Discovered while testing

MDL-63531 Add support for removal of context users - mod_assign