Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.4.5, 3.5.2, 3.6
-
Component/s: Messages
-
Testing Instructions:
- Confirm there are no '@message' tags in core (git grep "@message") - note, '@message_popup' is fine.
-
Affected Branches:MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
Fixed Branches:MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
Pull from Repository:
-
Pull 3.5 Branch:
MDL-63839_35 -
Pull 3.5 Diff URL:
-
Pull Master Branch:
MDL-63839_master -
Pull Master Diff URL:
Description
While looking to MDL-63549, by coincidence I saw that the @message tag was being used in some of the features. Searching over core, I saw this:
$ ag '@message[^_]' -l
|
|
|
message/tests/behat/search_messages.feature
|
message/tests/behat/delete_all_messages.feature
|
message/tests/behat/reply_message.feature
|
message/tests/behat/delete_messages.feature
|
message/tests/behat/search_users.feature
|
message/tests/behat/view_messages.feature
|
message/tests/behat/manage_contacts.feature
|
message/tests/behat/update_messaging_preferences.feature
|
message/output/popup/tests/behat/notification_popover_unread.feature
|
message/output/popup/tests/behat/message_popover_unread.feature
|
message/output/popup/tests/behat/notification_popover_preferences.feature
|
message/output/popup/tests/behat/message_popover_preferences.feature
|
Unless I'm wrong, component name @core_message should be used instead.
Attachments
Issue Links
- Discovered while testing
-
MDL-63549 Messaging: Create get_conversations based on data_for_messagearea_conversations
-
- Closed
-