Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63891

Backport MDL-57610 - scheduled task 'convert_submissions' should have a date/attempt check

    XMLWordPrintable

Details

    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_35_STABLE
    • Hide

      Covered by phpunit test.

      Show
      Covered by phpunit test.

    Description

      Thanks to the great work from Adam Olley & peer review by Damyon, the Moodle conversion task queue can now handle failures much better.

      I would strongly suggest that this gets backported to 3.4 & 3.5, please. Conversions are causing major operational issues at scale. Investigating things today we had 18 000+ unprocessed rows in the queue as a result of the lack of attempt checks (task initially got stuck a month ago). We are currently on 3.4 and planning to move to 3.5 LTS in summer 2019 with a view to remain on it until it's EOL in 2021. I don't think our users can accept that these conversion failures for the Moodle assignment remain uncaught for another 3 years if this major fix doesn't get backported.

       

      I see Damyon mentionned there was a new admin setting which was preventing the backport. If that's the case, the backport could simply ditch the setting and just stick to the default 3 failures required to get removed from the queue.

       

      Much appreciated.

      Alistair

       

      Attachments

        Issue Links

          Activity

            People

              markn Mark Nelson
              aspark Alistair Spark
              Damyon Wiese Damyon Wiese
              Adrian Greeve Adrian Greeve
              CiBoT CiBoT
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              16 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/18