Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63903

Ordering and blocktimes of php-rendered conversation messages is incorrect

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      1. Make sure you have at least two users on your site.
      2. Allow site-wide messaging ($CFG->messagingallusers=true or via Site Admin -> Advanced features)
      3. Go to the messaging UI
      4. Send some messages to a user and send some back as the other user.
      5. Now, load up the message/index page (YOURSITE/message/index.php) and click the conversation you created before. It MUST be the upper left conversation. (This is to trigger a web service load of the data)
      6. Note down the most recent message and the locations of the time headings above the messages. Most recent messages will be at the bottom.
      7. Now, reload the page using the browser controls but don't click anything.
      8. Verify** the layout of the loaded page is exactly the same as before, namely:

      • The ordering of the messages - recent at the bottom
      • The time headers above messages - there should NOT be a header above every single message.
      Show
      1. Make sure you have at least two users on your site. 2. Allow site-wide messaging ($CFG->messagingallusers=true or via Site Admin -> Advanced features) 3. Go to the messaging UI 4. Send some messages to a user and send some back as the other user. 5. Now, load up the message/index page (YOURSITE/message/index.php) and click the conversation you created before. It MUST be the upper left conversation. (This is to trigger a web service load of the data) 6.  Note down the most recent message and the locations of the time headings above the messages. Most recent messages will be at the bottom. 7. Now, reload the page using the browser controls but don't click anything. 8. Verify ** the layout of the loaded page is exactly the same as before, namely: The ordering of the messages - recent at the bottom The time headers above messages - there should NOT be a header above every single message.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63903-master

      Description

      This affects the current UI for messaging. NOT the new interface due to land in 3.6 soon.

      1. Send some messages to a user and send some back as that user.
      2. Now, load up the message/index page

      If you load the conversation by clicking it, this calls the OLD web service, and the messages are in the correct order.

      If you refresh the page on the conversation, the ordering comes from the new function, and the messages are out of order.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18