Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63910

Timing of course_module events

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.5, 3.5, 3.6
    • Fix Version/s: None
    • Component/s: Course, Events API
    • Testing Instructions:
      Hide
      Prerequisites:
      1. Install the following Turnitin plagiarism plugins:
      2. Install the Attached test local plugin mdl63910.zip.
      3. Go to "Site administration / Advanced features"
      4. Tick "Enable plagiarism plugins"
      5. Save the changes.
      6. Go to "Site administration / Plugins / Plagiarism / Turnitin plagiarism plugin"
      7. Tick "Enable Turnitin"
      8. Tick "Enable Turnitin for assign"
      9. Save changes.
      Testing
      1. Open a terminal and show the Apache error logs. For example:

        tail -f /var/logs/apache2/error.log
        

      2. Enable the plagiarism plugin
      3. Create an assignment and save
      4. Check the apache error logs which should read "Plagiarism: Correct!"
      5. Edit the assignment's settings
      6. Check the apache error logs which should read "Plagiarism: Correct!"

       

      Show
      Prerequisites: Install the following Turnitin plagiarism plugins: mod_turnitintooltwo plagiarism_turnitin Install the Attached test local plugin mdl63910.zip . Go to " Site administration / Advanced features " Tick " Enable plagiarism plugins " Save the changes. Go to " Site administration / Plugins / Plagiarism / Turnitin plagiarism plugin " Tick " Enable Turnitin " Tick " Enable Turnitin for assign " Save changes. Testing Open a terminal and show the Apache error logs. For example: tail -f /var/logs/apache2/error.log Enable the plagiarism plugin Create an assignment and save Check the apache error logs which should read "Plagiarism: Correct!" Edit the assignment's settings Check the apache error logs which should read "Plagiarism: Correct!"  
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-63910-master

      Description

      In the functions update_moduleinfo and create_moduleinfo the course_module_updated and course_module_created events are triggered before edit_module_post_actions.

      This means that the event is triggered before all the settings have been saved (in the case of plugins that hook into the course module settings. e.g. plagiarism).

      The events should be triggered after  all the settings have been saved.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 2 hours
                  1d 2h