Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63919

Disable notifications for automated SARs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.5, 3.5.2, 3.6
    • Fix Version/s: 3.3.9, 3.4.6, 3.5.3
    • Component/s: Privacy
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up SMTP/mailcatcher/mailhog
      2. Login as Admin.
      3. Go to Site administration > Users > Accounts > Add a new user.
      4. Add multiple users.
      5. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'.
      6. Enable the setting 'Create automatic data deletion requests'.
      7. Bulk delete some of the previously created users.
      8. Run the scheduled task to create delete data requests for pre-existing deleted users:

        php admin/tool/task/cli/schedule_task.php --execute='tool_dataprivacy\task\delete_existing_deleted_users
        

      9. Go to Site administration > Users > Privacy and policies > Data requests.
        1. make sure data delete data requests have been created for the deleted users (automatically created).
      10. Run cron

        php admin/cli/cron.php
        

        1. make sure the DPO(s)/Admin(s) have not received an email notification that a delete data requests have been created.
      11. Go to 'Site administration > Users > Privacy and policies > Data requests'.
      12. Create a Delete data request for one of the users.
      13. Go to Site administration > Users > Privacy and policies > Data requests.
        1. make sure data delete data request have been created for the deleted user (not automatically created).
      14. Run the adhoc task to initiate the created delete data requests

        php admin/cli/cron.php
        

        1. make sure the DPO(s)/Admin(s) have received an email notification that a delete data request has been created (You should also see a message in terminal "Message sent to ..."). 
      Show
      Set up SMTP/mailcatcher/mailhog Login as Admin. Go to Site administration > Users > Accounts > Add a new user. Add multiple users. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'. Enable  the setting 'Create automatic data deletion requests'. Bulk delete some of the previously created users. Run the scheduled task to create delete data requests for pre-existing deleted users: php admin/tool/task/cli/schedule_task.php --execute='tool_dataprivacy\task\delete_existing_deleted_users Go to Site administration > Users > Privacy and policies > Data requests. make sure data delete data requests have been created for the deleted users (automatically created). Run cron php admin/cli/cron.php make sure the DPO(s)/Admin(s) have not received an email notification that a delete data requests have been created. Go to 'Site administration > Users > Privacy and policies > Data requests'. Create a Delete data request for one of the users. Go to Site administration > Users > Privacy and policies > Data requests. make sure data delete data request have been created for the deleted user (not automatically created). Run the adhoc task to initiate the created delete data requests php admin/cli/cron.php make sure the DPO(s)/Admin(s) have received an email notification that a delete data request has been created ( You should also see a message in terminal "Message sent to ...") .  
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63919-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      As per Chris Clark's comment in MDL-62563, we should try and rate limit these somehow.

      I'd recommend we not send any notification for automated SARs, though this will mean that users who are bulk deleted are also not notified about. Still, better than spamming POs/admins.

        Attachments

        1. mailhog_master.png
          70 kB
          Eloy Lafuente (stronk7)
        2. mailhog_stables.png
          68 kB
          Eloy Lafuente (stronk7)

          Issue Links

            Activity

              People

              Assignee:
              Geshoski Mihail Geshoski
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Michael Hawkins
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18