Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63924

shared_data_provider should have shared_userlist

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.5, 3.5.2, 3.6
    • Fix Version/s: 3.4.6, 3.5.3
    • Component/s: Privacy
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Site administration->Users -> Privacy & Policies -> Plugin registry
      3. Choose "Expand all"
      4. Search for "Userlist provider missing"
        1. Confirm that you don't see any results
          NOTE: There will be one result for the core_favourites,core_backup and block_recentlyaccesseditems subsystems for MASTER only because it has not yet been written. This is expected and does not constitute a fail
      5. Apply the attached patch to the branch:

        git am 0001-MDL-63924-privacy-Add-test-to-ensure-shared_data_pro.patch
        

      6. Initialise phpunit

        php admin/tool/phpunit/cli/init.php
        

      7. Run phpunit

        ./vendor/bin/phpunit privacy/tests/provider_test.php
        

        1. Confirm passes
          NOTE: There is a known failure for the favourites subsystem for MASTER only because it has not yet been written. This is expected
      Show
      Login as admin Navigate to Site administration->Users -> Privacy & Policies -> Plugin registry Choose "Expand all" Search for " Userlist provider missing " Confirm that you don't see any results NOTE: There will be one result for the core_favourites,core_backup and block_recentlyaccesseditems subsystems for MASTER only because it has not yet been written. This is expected and does not constitute a fail Apply the attached patch to the branch: git am 0001-MDL-63924-privacy-Add-test-to-ensure-shared_data_pro.patch Initialise phpunit php admin/tool/phpunit/cli/init.php Run phpunit ./vendor/bin/phpunit privacy/tests/provider_test.php Confirm passes NOTE: There is a known failure for the favourites subsystem for MASTER only because it has not yet been written. This is expected
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63924-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      I realised today that we are missing this.

      It's far too late to add this to stables, and many of the areas have actually been done already (they're just missing the interface to say so).

      We have a core_user_data_provider. Where this is implemented we are requiring that a core_userlist_provider also be implemented.

      Equally we have a shared_data_provider which is used by subsystems, and subplugins which do not store data but provide data to others. This needs to have a shared_userlist_provider too.

      I'd propose that we just add the empty interfaces now so that they can be used consistently in the future. Later on we can add the tests for them.
      This is largely an accounting thing and will only be used in unit tests, and the plugin registry.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h