Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63927

Update jmeter performance plan to use the new login token

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      There are 2 ways to test this:

      1) locally, installing and running the tool. I've uploaded the results of that, and it's easy to see that, now, login is happening and the rest of requests (view course, page, post...) are doing things (there are dbwrites). Without the patch, basically all requests were the same (login failed) and dbwrites values were always in [0, 1] range. Configure the tool in webserver_config.properties to use 'git://git.moodle.org/integration.git' as 'beforebranchrepository' and 'afterbranchrepository', and 'master' as 'beforebranch' and 'afterbranch'.

      2) Applying for the change in HQ performance infrastructure. To do so:

      • Disable the $CFG->disablelogintoken temporal fix.
      • Relaunch a comparison from https://ci.moodle.org
      • Verify results have sense, dbwrites are back. It doesn't matter if it's leading to a pass or a fail at the moment it's tested. Just that it's back to work.
      Show
      There are 2 ways to test this: 1) locally, installing and running the tool . I've uploaded the results of that , and it's easy to see that, now, login is happening and the rest of requests (view course, page, post...) are doing things (there are dbwrites). Without the patch, basically all requests were the same (login failed) and dbwrites values were always in [0, 1] range. Configure the tool in webserver_config.properties to use 'git://git.moodle.org/integration.git' as 'beforebranchrepository' and 'afterbranchrepository', and 'master' as 'beforebranch' and 'afterbranch'. 2) Applying for the change in HQ performance infrastructure. To do so: Disable the $CFG->disablelogintoken temporal fix. Relaunch a comparison from https://ci.moodle.org Verify results have sense, dbwrites are back. It doesn't matter if it's leading to a pass or a fail at the moment it's tested. Just that it's back to work.
    • Workaround:
      Hide
      Show
      Set $CFG->disablelogintoken in config.php.template .
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:

      Description

      It has been detected that the performance comparator had stopped to work recently.

      Ultimately the cause is that, now, the login process has stopped working because of the new login token introduced by MDL-63183.

      This issue is about to modify the jmeter plan to support those new login tokens.

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            David Monllaó
            Integrator:
            Damyon Wiese
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Dec/18