Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63959

Nested dependency logic fails in feedback activity

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Restore the attached file within a course
      2. Login as a student and view the activity in the course
      3. Take the feedback activity as a student. Answer "No" to the first question.
        1. Confirm that The user is correctly directed to the question "What mode of transportation do you most often use to get to school?"
      4. Respond to this question.
        1. Confirm that the user should be directed to the final question ("What is your satisfaction level with your primary mode of transportation?").
      Show
      Restore the attached file within a course Login as a student and view the activity in the course Take the feedback activity as a student. Answer "No" to the first question. Confirm that The user is correctly directed to the question "What mode of transportation do you most often use to get to school?" Respond to this question. Confirm that the user should be directed to the final question ("What is your satisfaction level with your primary mode of transportation?").
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-63959-master

      Description

      DESCRIPTION
      When a feedback activity contains nested dependence items such that the second dependence item will only be answered by some respondents based on their answer to the first dependence item, users may be delivered questions that are supposed to be dependent on the second dependence item that the user never received.

      Using the example feedback questions below, the initial dependency on the "DRIVE" question works correctly. The respondent receives the appropriate second question based on their response to "DRIVE". If the respondent answers "Yes" to "DRIVE" they are taken to the question "Origin" which serves as a second dependence item. The subsequent question delivered to the respondent is appropriately conditioned based on the response to "Origin". Lastly, the user receives the final, required question.

      However, if the respondent answers "No" to the first dependence item, "DRIVE", they will never be requested to answer the second dependence item, "Origin". As such, the expectation is that the respondent would not receive either of the questions which use "Origin" as a dependence item. Yet, the respondent is delivered both of those questions as well as the final, required question.

      STEPS TO REPLICATE
      1. Create a new feedback activity.
      2. Add questions (all multiple choice) as outlined below (* denotes required questions)

      	(DRIVE) Do you drive to school?*
      		Yes
      		No
      	
      	Page Break
      	
      	What mode of transportation do you most often use to get to school? (DRIVE->No)
      		Bike
                      Bus
      		Carpool
      		Walk
      	
      	Page Break
      	
      	(Origin) Is your automobile made by a domestic or foreign manufacturer? (DRIVE->Yes)
      		Domestic
      		Foreign
      	
      	Page Break
      	
      	What Domestic manufacturer built your automobile? (Origin>Domestic)
      		Chrysler
      		Ford
      		General Motors
      		Other
      	
      	Page Break
      	
      	What Foreign manufacturer built your automobile? (Origin>Foreign)
      		BMW
      		Honda
      		Hyundai
      		Kia
      		Mazda
      		Nissan
      		Toyota
      		Volkswagen
      		Other
      	
      	Page Break
      	
      	What is your satisfaction level with your primary mode of transportation?*
      		1 - Very Unsatisfied
      		2 - Unsatisfied
      		3 - Neutral
      		4 - Satisfied
      		5 - Very Satisfied
      	

      3. Take the feedback activity as a student. Answer "No" to the first question.
      4. The user is correctly directed to the question "What mode of transportation do you most often use to get to school?" Respond to this question.

      OBSERVED BEHAVIOR:
      The user is directed the question "What Domestic manufacturer built your automobile?" and after that to the question "What Foreign manufacturer built your automobile?".

      EXPECTED BEHAVIOR:
      The user is directed to the final question.

        Attachments

        1. backup-moodle2-activity-2-feedback2-20190430-0718-nu.mbz
          3 kB
          Tobias Reischmann
        2. MDL-63959.jpg
          17 kB
          Anna Carissa Sadia

          Issue Links

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 21 minutes
                  1h 21m