[MDL-63968] get_conversations get_in_or_equal with NOT - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.6
Fix Version/s: 3.6
Component/s: Messages
Labels:
- ci

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Add the ability to message a group of users
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-63968~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/208950cff0...MDL-63968-master
Testing Instructions:
1. Tested by CI

Description

                list ($insql, $inparams) = $DB->get_in_or_equal($favouriteconversationids, SQL_PARAMS_NAMED, 'favouriteids');

                $favouritesql = $favourites ? " AND mc.id {$insql} " : " AND mc.id NOT {$insql} ";

You should not use the "NOT" - please use the extra argument to get_in_or_equal.
The get_in_or_equal function will return "= ?" or "<> ?" if there is only one array key. Your SQL will then become:

AND mc.id NOT = ?

Attachments

Issue Links

Discovered while testing

MDL-63850 Extend member info with additional fields

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Jake Dallimore

Integrator:: David Monllaó

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, David Monllaó, Jake Dallimore

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 12/Nov/18 8:25 AM

Updated:: 13/Nov/18 11:03 PM

Resolved:: 13/Nov/18 11:03 PM

Fix Release Date:: 3/Dec/18