Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6.1, 2.1.1
    • Fix Version/s: 2.2
    • Labels:
      None
    • Environment:
      All

      Description

      The label for this option currently reads:

      "number of latest entries to show, 0 to disable RSS"

      The value in the drop down is "None" not "0"

      suggest update to:

      number of latest entries to show or "None" to disable RSS

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            It looks like that string isn't being used at all anymore although its still in the database activity language file.
            $string['rsshowmany'] = '(number of latest entries to show, 0 to disable RSS)';

            Currently the string that is displayed is
            $string['numberrssarticles'] = 'RSS articles';
            which neatly avoids the whole 0 Vs none issue.

            Show
            andyjdavis Andrew Davis added a comment - It looks like that string isn't being used at all anymore although its still in the database activity language file. $string ['rsshowmany'] = '(number of latest entries to show, 0 to disable RSS)'; Currently the string that is displayed is $string ['numberrssarticles'] = 'RSS articles'; which neatly avoids the whole 0 Vs none issue.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew this has been integrated now
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            All strings are visible.
            Thanks for fixing this Andrew

            Note:
            I think this should be applied to 21, 20 and 19 as well.

            Show
            rajeshtaneja Rajesh Taneja added a comment - All strings are visible. Thanks for fixing this Andrew Note: I think this should be applied to 21, 20 and 19 as well.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11