Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63973

Display always related badges, regardless who has added the relation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as a teacher and go to a course.
      2. Click the gear menu and select 'Manage badges'
      3. Create a new badge calling it 'badge 1'.
      4. Complete the form, then click the button 'Create badge'.
      5. Add a 'Manual issue by role' criterion and select Teacher as the role.
      6. Don't enable access to the badge yet.
      7. Repeat the above and create a second badge, but do not enable access to it yet. Call this 'unrelated badge'.
      8. Repeat the above and create a second badge, but do not enable access to it yet. Call this 'badge 2'.
      9. On the 'Related badges' tab of 'badge 2', add a related badge and select 'badge 1'.
      10. Verify you see a count of '1' next to the related badges text in the tab and that you see the 'badge 1' listed as related
      11. Click 'Add related badge' again and verify you can't link the same badge again but that you see 'unrelated badge' listed.
      12. Now, go back to 'badge 1' via 'Manage badges' in the breadcrumbs
      13. Verify you see a count of '1' next to the related badges text in the tab
      14. Click related badges and verify you see the 'badge 2' listed as related.
      15. Click 'Add related badge' verify you cannot add 'badge 2' but that you see 'unrelated badge' listed.
      16. Next, click the trash icon and delete the related badge, 'badge 2'. Verify this works and that you see the 'This badge does not have related badges' text.
      17. Now, click 'add related badge' and verify you see 'badge 2' listed.
      18. Select 'badge 2' and confirm.
      19. Verify you see 'badge 2' listed as being related.
      20. Again, using the trash icon delete the relationship. Verify this works and that you see the 'This badge does not have related badges' text.
      21. Now, link 'badge 2' again.
      22. Back on the 'manage badges' page, enable access to both badges.
      23. Assign 'badge 1' to a student.
      24. Log in as the student, view the notification and click the link to the badge.
      25. Verify you are viewing 'badge 1' and that 'badge 2' is listed as being related.
      Show
      Log in as a teacher and go to a course. Click the gear menu and select 'Manage badges' Create a new badge calling it 'badge 1'. Complete the form, then click the button 'Create badge'. Add a 'Manual issue by role' criterion and select Teacher as the role. Don't enable access to the badge yet. Repeat the above and create a second badge, but do not enable access to it yet. Call this 'unrelated badge'. Repeat the above and create a second badge, but do not enable access to it yet. Call this 'badge 2'. On the 'Related badges' tab of 'badge 2', add a related badge and select 'badge 1'. Verify you see a count of '1' next to the related badges text in the tab and that you see the 'badge 1' listed as related Click 'Add related badge' again and verify you can't link the same badge again but that you see 'unrelated badge' listed. Now, go back to 'badge 1' via 'Manage badges' in the breadcrumbs Verify you see a count of '1' next to the related badges text in the tab Click related badges and verify you see the 'badge 2' listed as related. Click 'Add related badge' verify you cannot add 'badge 2' but that you see 'unrelated badge' listed. Next, click the trash icon and delete the related badge, 'badge 2'. Verify this works and that you see the 'This badge does not have related badges' text. Now, click 'add related badge' and verify you see 'badge 2' listed. Select 'badge 2' and confirm. Verify you see 'badge 2' listed as being related. Again, using the trash icon delete the relationship. Verify this works and that you see the 'This badge does not have related badges' text. Now, link 'badge 2' again. Back on the 'manage badges' page, enable access to both badges. Assign 'badge 1' to a student. Log in as the student, view the notification and click the link to the badge. Verify you are viewing 'badge 1' and that 'badge 2' is listed as being related.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63973-master

      Description

      Let's say we have 2 badges A and B. From the current implementation if I add B to A's related badges, it won't be able to see this relation from the B related badges page.

      We should display always these relations, regardless who has created them.

        Attachments

        1. MDL-63973.PNG
          113 kB
          Anna Carissa Sadia

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h