[MDL-63995] timeline, recentlyaccessedcourses, recentlyaccesseditems, starredcourses, myoverview blocks should not have an addinstance capability - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6
Fix Version/s: 3.7
Component/s: Blocks, Dashboard (My home), Roles / Access
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
https://github.com/chocolate-lightning/moodle.git
Pull Master Branch:
~~MDL-63995~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...chocolate-lightning:MDL-63995-master
Testing Instructions:
Hide

Log in as admin.

Visit "Site administration ► Users ► Permissions ► Capability overview".

Make sure the following capabilities are not listed:
block/timeline:addinstance
block/recentlyaccessedcourses:addinstance
block/recentlyaccesseditems:addinstance
block/starredcourses:addinstance
block/myoverview:addinstance

Visit "Site administration ► Users ► Permissions ► Define roles".

Access to the editing page for the "Authenticated user" role.

Make sure the following capabilities are not listed:
block/timeline:addinstance
block/recentlyaccessedcourses:addinstance
block/recentlyaccesseditems:addinstance
block/starredcourses:addinstance
block/myoverview:addinstance

Visit a course page, turn editing on,

Make sure no debugging notices are displayed on the page.

Timeline

Recently accessed courses

Recently accessed items

Starred courses

My OverviewGo to the Dashboard (/my) and add the following blocks to the page (if not already added) and make sure no debugging notices are displayed:
Show
Log in as admin. Visit " Site administration ► Users ► Permissions ► Capability overview ". Make sure the following capabilities are not listed: block/timeline:addinstance block/recentlyaccessedcourses:addinstance block/recentlyaccesseditems:addinstance block/starredcourses:addinstance block/myoverview:addinstance Visit " Site administration ► Users ► Permissions ► Define roles ". Access to the editing page for the "Authenticated user" role. Make sure the following capabilities are not listed: block/timeline:addinstance block/recentlyaccessedcourses:addinstance block/recentlyaccesseditems:addinstance block/starredcourses:addinstance block/myoverview:addinstance Visit a course page, turn editing on, Make sure no debugging notices are displayed on the page. Timeline Recently accessed courses Recently accessed items Starred courses My OverviewGo to the Dashboard (/my) and add the following blocks to the page (if not already added) and make sure no debugging notices are displayed:

Description

The new Dashboard blocks Timeline, Recently accessed courses, Recently accessed items, Starred courses and Course overview can only be added to the Dashboard (controlled by a myaddinstance capability).

It is not possible to add any of the blocks to a course page, so there is no need for an addinstance capability. Thus, the following capabilities need to be removed:

block/timeline:addinstance
block/recentlyaccessedcourses:addinstance
block/recentlyaccesseditems:addinstance
block/starredcourses:addinstance
block/myoverview:addinstance

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-63995_Step 2 and 4.jpg.png
169 kB
27/Mar/19 5:39 PM
MDL-63995_Step 6-7.jpg.png
128 kB
27/Mar/19 5:39 PM
MDL-63995_Step 6-7 (My Overview).jpg.PNG
41 kB
27/Mar/19 5:39 PM

Issue Links

caused a regression

MDL-65502 Regression: Cannot add/remove dashboard blocks to default dashboard. (master)

Closed

Activity

People

Assignee:: Dan Marsden

Reporter:: Helen Foster

Peer reviewer:: Mathew May

Integrator:: Jun Pataleta

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Dan Marsden, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Helen Foster, Jun Pataleta, Mathew May

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 14/Nov/18 1:50 AM

Updated:: 15/May/19 9:48 PM

Resolved:: 29/Mar/19 12:24 AM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Remaining:

Logged:

2h 30m