Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64008

Optional badge fields should not be displayed on the badge page when empty

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as a teacher and go to a course.
      2. Click 'Add a new badge' (either via the gear menu or the Administration block, depending upon the theme)
      3. Complete the form but only fill out the required fields, then click the button 'Create badge'.
      4. Add a 'Manual issue by role' criterion and select Teacher as the role.
      5. Enable access to the badge.
      6. Assign the badge to a student.
      7. Under the Recipients tab click the "View issued badge" link next to a user.
      8. Check that there are no fields that display nothing.
      9. Create a new badge (following the steps above).
      10. This time add a few of the non required fields.
      11. Assign a badge to a student and view their badge.
      12. Check that the fields that were filled out are displayed.
      Show
      Log in as a teacher and go to a course. Click 'Add a new badge' (either via the gear menu or the Administration block, depending upon the theme) Complete the form but only fill out the required fields, then click the button 'Create badge'. Add a 'Manual issue by role' criterion and select Teacher as the role. Enable access to the badge. Assign the badge to a student. Under the Recipients tab click the "View issued badge" link next to a user. Check that there are no fields that display nothing. Create a new badge (following the steps above). This time add a few of the non required fields. Assign a badge to a student and view their badge. Check that the fields that were filled out are displayed.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64008-master

      Description

      As found when testing MDLQA-12705, the optional badge fields - version, image author's name, email, URL and image caption - are displayed on the badge page when empty. This doesn't look good, as illustrated in the attached screenshot. Also, maybe the language can be omitted too?

      Steps to reproduce:

      1. Create a new badge, filling in only the required fields.
      2. Assign it to a user.
      3. Go to the user's profile page and click on the badge.

      Expected result: Optional badge fields are not displayed on the badge page when empty.

       

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m