Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64012

Auto-linking not working if title has brackets

XMLWordPrintable

    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • Hide

      The unit test coverage should be suffcient. If you want to do a maual test, repeat the steps to reproduce:

      • Create a page resource with name like "Test (2)"
      • Create a label with text "Please read the page Test (2)."
      • Verify that the words 'Test (2)' are made into a link on the course page.
      Show
      The unit test coverage should be suffcient. If you want to do a maual test, repeat the steps to reproduce: Create a page resource with name like "Test (2)" Create a label with text "Please read the page Test (2)." Verify that the words 'Test (2)' are made into a link on the course page.

      Step-by-step instructions:

      1. Go to a course and turn editing on
      2. Create a file resource named "Test 1"
      3. Create a file resource named "Test (2)"
      4. Add a new activity e.g Label with following content: "Please read Test 1 and Test (2)"
      5. Check the result

      Expected result:

      • The label should link to the two file resources.

      Actual result:

      • The auto-linking works only to the resource without brackets in the title.

      Additional information:

      The filter/glossary had only one change (https://github.com/moodle/moodle/commits/MOODLE_35_STABLE/filter/glossary) in the recent time.

      In due of that, I think it's a regression of MDL-63403.

      I can confirm that with Moodle 3.5.2+ (Build: 20181005) it was working like the expected result.

        1. glossaty_filter.png
          glossaty_filter.png
          10 kB
        2. image-2018-12-05-17-08-20-145.png
          image-2018-12-05-17-08-20-145.png
          75 kB
        3. image-2018-12-06-09-08-43-961.png
          image-2018-12-06-09-08-43-961.png
          15 kB
        4. screenshot-1.png
          screenshot-1.png
          33 kB

            timhunt Tim Hunt
            pead Adrian Perez
            Jan Dageförde Jan Dageförde
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 minutes
                7m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.