Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64025

Admin bookmarks block fails to bookmark Admin categories

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log into Moodle with admin account
      2. Go to Site administration and click the "Blocks editing on" button.
      3. The Admin Bookmarks block should appear either on the bottom left (clean) or right (boost)
      4. In the Admin bookmarks block, do Cog → "Configure Admin bookmarks block" and set "Display on page types" to "Any site administration page" and save changes.
      5. Visit a category page in the admin settings,
        e.g. /admin/category.php?category=analytics (see screenshot)
      6. Click on "Bookmark this page" in the admin bookmarks block
      7. Confirm that the link to the category is added as a bookmark to the admin bookmarks block.
      8. Click on the link that was just added and confirm that you are redirected to the page bookmarked.
      9. Click on the "Unbookmark this page" link in the admin bookmarks block.
      10. Confirm that the link is removed from the block and there is no error.
      Show
      Log into Moodle with admin account Go to Site administration and click the "Blocks editing on" button. The Admin Bookmarks block should appear either on the bottom left (clean) or right (boost) In the Admin bookmarks block, do Cog → "Configure Admin bookmarks block" and set "Display on page types" to "Any site administration page" and save changes. Visit a category page in the admin settings, e.g. /admin/category.php?category=analytics (see screenshot) Click on "Bookmark this page" in the admin bookmarks block Confirm that the link to the category is added as a bookmark to the admin bookmarks block. Click on the link that was just added and confirm that you are redirected to the page bookmarked. Click on the "Unbookmark this page" link in the admin bookmarks block. Confirm that the link is removed from the block and there is no error.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64025-master
    • Pull Master Diff URL:

      Description

      You can bookmark admin pages with the "Admin bookmarks" block, but when on a Admin category page hitting the Bookmark button gives an 'Invalid section' error.

      To reproduce:

      1. Log in as Admin
      2. Make sure in Site administration → Navigation 'linkadmincategories' is enabled.
      3. Navigate to Site administration → Language (admin/category.php?category=language)
      4. Click on the "Bookmark this page" Link in the Admin bookmarks block on the right hand side.

      WHAT YOU EXPECTED: The 'Language' category page is bookmarked.

      WHAT ACTUALLY HAPPENS: An 'Invalid section' error occurs.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-64374 Not All Site Administration Pages Can be Bookmarked when using the Boost theme

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              christianwolters Christian Wolters
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Luca Bösch Luca Bösch
              Integrator:
              Adrian Greeve Adrian Greeve
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m