Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64045

Error when trying to favourite a user when no conversation exists

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Requirements

      1. Please test this on both Clean and Boost themes

      Favouring uncreated conversation

      1. Create a site with two users, s1 and s2
      2. Create a course and enrol both users
      3. Log in as each user and make sure that their messaging privacy settings are set to “My contacts and anyone in my courses”
        • open message drawer > click the setting (cog icon)
      4. Log in as s1
      5. Open message drawer
      6. Search for the s2 user by their name
      7. Click on the user to go to the conversation
      8. Click the dropdown menu (ellipsis icon) in the header next to the other user’s name
      9. CONFIRM that the menu doesn’t contain an option to add or remove this conversation as a favourite
      10. Send a message to the user (this creates the conversation)
      11. Open the dropdown menu again
      12. CONFIRM that you now see an option to favourite the conversation

      Regression testing personal message

      1. Add another user to the site and add them to the course
      2. Start a conversation with them and send them a few messages
      3. Log out, and log in as the other user
      4. Open the message drawer and view the conversation
      5. Add it as a favourite from the dropdown menu
      6. CONFIRM it shows the favourite star in the header
      7. Click the “back” arrow in the top of the message drawer to go back to the overview
      8. CONFIRM that the conversation has been moved into the favourites section
      9. View the conversation again and remove it from favourites
      10. CONFIRM that the favourites star is hidden
      11. Click the back arrow
      12. CONFIRM that it has moved out of the favourites section back into “messages”
      13. Reload the page and confirm it’s still there

      Regression testing group message

      1. Create a group conversation by creating a group in the course, adding each of the users to the group and setting “Yes” for creating a group conversation in the group settings page
      2. Repeat the testing above for favouriting / unfavouriting the group conversation
      Show
      Requirements Please test this on both Clean and Boost themes Favouring uncreated conversation Create a site with two users, s1 and s2 Create a course and enrol both users Log in as each user and make sure that their messaging privacy settings are set to “My contacts and anyone in my courses” open message drawer > click the setting (cog icon) Log in as s1 Open message drawer Search for the s2 user by their name Click on the user to go to the conversation Click the dropdown menu (ellipsis icon) in the header next to the other user’s name CONFIRM that the menu doesn’t contain an option to add or remove this conversation as a favourite Send a message to the user (this creates the conversation) Open the dropdown menu again CONFIRM that you now see an option to favourite the conversation Regression testing personal message Add another user to the site and add them to the course Start a conversation with them and send them a few messages Log out, and log in as the other user Open the message drawer and view the conversation Add it as a favourite from the dropdown menu CONFIRM it shows the favourite star in the header Click the “back” arrow in the top of the message drawer to go back to the overview CONFIRM that the conversation has been moved into the favourites section View the conversation again and remove it from favourites CONFIRM that the favourites star is hidden Click the back arrow CONFIRM that it has moved out of the favourites section back into “messages” Reload the page and confirm it’s still there Regression testing group message Create a group conversation by creating a group in the course, adding each of the users to the group and setting “Yes” for creating a group conversation in the group settings page Repeat the testing above for favouriting / unfavouriting the group conversation
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-64045-master

      Description

      Try to favourite a user via the ellipsis menu when no messages have been sent to/from them. You'll see an exception because a conversation must exist in order for it to be marked as a favourite conversation.

      Suggestion: remove the 'Favourite' action from the UI unless we know a conversation exists.

        Attachments

        1. screenshot-1.png
          screenshot-1.png
          34 kB
        2. 1.PNG
          1.PNG
          111 kB
        3. 2.PNG
          2.PNG
          98 kB
        4. 3.PNG
          3.PNG
          112 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h