[MDL-64049] get_user_preferences caching - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.3, 3.6
Fix Version/s: 3.5.4
Component/s: General, Performance
Labels:
- ci
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-64049~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/01acb1ea90...MDL-64049-master
Testing Instructions:
Hide

Copy the attached test.php into the document root

Login to Moodle

Access /test.php in the site

Confirm you get an empty page

Before this patch there is one call to fetch the DB records per call to get_user_preferences().
Show
Copy the attached test.php into the document root Login to Moodle Access /test.php in the site Confirm you get an empty page Before this patch there is one call to fetch the DB records per call to get_user_preferences() .

Description

When get_user_preferences is called with the id of the current user it does not make use of the cache in the current $USER object.

We can make use of the $USER when $userid matches $USER->id.

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
26 kB
20/Nov/18 8:57 AM
test.php
0.3 kB
16/Nov/18 2:09 PM

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Peter Dias

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Peter Dias

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Nov/18 1:56 PM

Updated:: 20/Nov/18 11:24 PM

Resolved:: 20/Nov/18 11:24 PM

Fix Release Date:: 14/Jan/19

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

10m