[MDL-64049] get_user_preferences caching - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Copy the attached test.php into the document root

Login to Moodle

Access /test.php in the site

Confirm you get an empty page

Before this patch there is one call to fetch the DB records per call to get_user_preferences().
Show
Copy the attached test.php into the document root Login to Moodle Access /test.php in the site Confirm you get an empty page Before this patch there is one call to fetch the DB records per call to get_user_preferences() .
Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-64049~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/01acb1ea90...MDL-64049-master

When get_user_preferences is called with the id of the current user it does not make use of the cache in the current $USER object.

We can make use of the $USER when $userid matches $USER->id.

Estimated:

Not Specified

Remaining:

Logged:

10m