Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64063

Timeline wrongly lists events for students suspended in a course

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create or use an existing course.
      2. Make sure you have some students enrolled in the course.
      3. Create one of the following activities and set a closing date.
        • Workshop
        • Quiz
        • SCORM
        • Database
        • Choice
        • Lesson
        • Feedback
        • Chat
      4. Suspend a student.
        1. Go to "Course administration > Users > Enrolled users" and click the settings cog next to the user you want to suspend.
        2. Set status to Suspended and click save changes.
      5. Log in as the student and go to the dashboard.
      6. Check that the timeline block (you may have to add it) does not show any activites for the course that they are suspended in.
      7. Log in as a different student, go to the dashboard, and check that they do see activities in the same course.
      Show
      Create or use an existing course. Make sure you have some students enrolled in the course. Create one of the following activities and set a closing date. Workshop Quiz SCORM Database Choice Lesson Feedback Chat Suspend a student. Go to "Course administration > Users > Enrolled users" and click the settings cog next to the user you want to suspend. Set status to Suspended and click save changes. Log in as the student and go to the dashboard. Check that the timeline block (you may have to add it) does not show any activites for the course that they are suspended in. Log in as a different student, go to the dashboard, and check that they do see activities in the same course.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-64063-master

      Description

      Scenario:
      1. Log in as Teacher, add activities with deadlines / closing dates, or activities with only opening dates (without closing dates), and / or set Expected completion dates.
      2. Suspend a student in a course, or terminate their enrolment in the course by imposing his/her enrolment end date
      3. Log in as the suspended / not current student and go to the Dashboard > Timeline.
      4. See deadlines / closing dates (opening dates where relevant) and Expected completions dates for many activities which the suspended students should NOT see - clicking on the shown links will take the student to the course enrolment page, while the activity of course cannot be taken.

      This leaky filtering affects the Timeline only. The filtering applied in the Calendar (and Upcoming events block where relevant) works correctly.

      UPDATE 2018-11-17 21:32: Moodle 3.6 dev+: Timeline > Sort by dates is affected ONLY, whereas Timeline > Sort by courses correctly excludes those courses where the student is suspended / not current.

      Expected completion date setting causes the Timeline leak for EACH activity and resource, as I have been able to establish.

      As far as the Availability / Timing / Deadline settings, the following activities are affected (slip through for suspended students):

      • Workshop - deadline for submission
      • Workshop - opening date for submission (shown in Timeline when closing date is not set)
      • Workshop - deadline for assessment
      • Workshop - opening date for assessment (shown in Timeline when closing date is not set)
      • Quiz - closing date
      • Quiz - opening date (shown in Timeline when closing date is not set)
      • SCORM closing date
      • SCORM - opening date (shown in Timeline when closing date is not set)
      • Database closing date
      • Database opening date (shown in Timeline when closing date is not set)
      • Choice closing date
      • Choice opening date (shown in Timeline when closing date is not set)
      • Lesson closing date
      • Lesson opening date (shown in Timeline when closing date is not set)
      • Feedback closing date
      • Feedback opening date (shown in Timeline when closing date is not set)
      • Chat - opening/first session date

      The dates on which the report above is based were all dates in the future. 

      This very detailed check was made when testing the Moodle 3.6 dev master version on 2018-11-15.

      UPDATE 2018-11-17 21:45 : I have specifically tested 3.5.2 now and canNOT reproduce the problem, so my earlier report that this version is affected must stand corrected. I have therefore removed 3.5.2 from the affected versions.

        Attachments

        1. 2018-11-14 , 23_31_05 - Dashboard - Google Chrome.png
          182 kB
          Przemek Kaszubski
        2. 2018-11-14 , 23_43_50 - Dashboard - Google Chrome.png
          65 kB
          Przemek Kaszubski
        3. 2018-11-23 , 21_23_42 - Dashboard - Mozilla Firefox (tryb prywatny).png
          104 kB
          Przemek Kaszubski
        4. image-2018-11-21-14-58-19-465.png
          77 kB
          Janelle Barcega
        5. MDL-64063-33.mdk.patch
          3 kB
          Adrian Greeve
        6. MDL-64063-34.mdk.patch
          3 kB
          Adrian Greeve
        7. MDL-64063-35.mdk.patch
          3 kB
          Adrian Greeve
        8. MDL-64063-master.mdk.patch
          3 kB
          Adrian Greeve

          Issue Links

            Activity

              People

              • Assignee:
                abgreeve Adrian Greeve
                Reporter:
                pmk Przemek Kaszubski
                Peer reviewer:
                Mihail Geshoski
                Integrator:
                David Monllaó
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 10 minutes
                  1h 10m