Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64077

Styling updates on main menu edit

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.3, 3.6
    • Fix Version/s: 3.5.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin.
      2. Navigate to "Site home"
      3. Turn editing on from the cog menu
      4. Add the "Main menu" block
      5. Add four activities to it including:
        1. at least one label
        2. at least one non-label
        3. One URL resource with "Display" (under Appearance category) set to "In pop-up".
      6. Indent two of them.
        1. Confirm that it displays correctly.
      7. Move them to the general section of the front page (click - you can't drag here).
        1. Confirm that the indenting is still displayed correctly.
      8. Change the indenting on one of them.
      9. Move them both back to the block.
        1. Confirm the indenting is still OK.
        2. Confirm there isn't additional white space between a label and its action buttons.
        3. Confirm action buttons are aligned to the right of the block.
      10. Follow Site administration > Pugins >Activity modules> URL and select "New window" option in "Available display options".
      11. Change URL resource "Display" option to "In new Window" and save.
        1. Ensure page looks as expected and you can still drag the block.
      Show
      Log in as an admin. Navigate to "Site home" Turn editing on from the cog menu Add the "Main menu" block Add four activities to it including: at least one label at least one non-label One URL resource with "Display" (under Appearance category) set to "In pop-up". Indent two of them. Confirm that it displays correctly. Move them to the general section of the front page (click - you can't drag here). Confirm that the indenting is still displayed correctly. Change the indenting on one of them. Move them both back to the block. Confirm the indenting is still OK. Confirm there isn't additional white space between a label and its action buttons. Confirm action buttons are aligned to the right of the block. Follow Site administration > Pugins >Activity modules> URL and select "New window" option in "Available display options". Change URL resource "Display" option to "In new Window" and save. Ensure page looks as expected and you can still drag the block.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64077-master

      Description

      There are a couple of issues brought up during QA tests (Refer boost and clean attachments for comparisons):

      1. The same move icon used in boost is not coming through in clean.
      2. There is some additional white space between a label and it's action buttons
      3. Based on the QA tester's feedback, he expected the action buttons to be inline to the title

      Edit: Attachments taken from qa on 19/11

        Attachments

        1. boostFixed.png
          boostFixed.png
          43 kB
        2. cleanFixed.png
          cleanFixed.png
          41 kB
        3. CleanMainMenu.png
          CleanMainMenu.png
          21 kB
        4. MainMenu.png
          MainMenu.png
          20 kB
        5. MDL-64077.PNG
          MDL-64077.PNG
          37 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m