Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64092

Timeline needlessly provides (faulty) edit submission links to assignments recently overdue which also have a recent cut-off date

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test with both clean and boost.

      Prerequisites:
      1. Have timeline block in dashboard
      2. A course
      3. 4 students enrolled
      4. Create assignments for the following scenarious (1 each):
        1. Allow submissions from 5 days ago with due date 5 days in the future
          1. Add User Overrides for student 2 with Cut-off date 1 day ago, and all other dated not enabled
        2. Allow submissions from 5 days ago with Due date in 5 days AND Cut-off date in 10 days
          1. Add User Overrides for student 3 with the Due date 3 days ago, and all other dates not enabled
        3. Allow submissions from 5 days ago with Due date 3 days ago
        4. Allow submissions from 5 days ago with Due date 3 days ago and Cut-off date 2 days ago
          1. Add User Overrides for student 4 with Due date 1 day ago, cut-off date in 1 day, and other dates not enabled
        5. Allow submissions from 5 days in the future with Due date in 10 days and Cut-off date in 11 days
      Instructions:
      1. Login as a the first student
      2. In the timeline block, change the filter to "All"
        1. Confirm you can see all 5 assignments
        2. Confirm that you see an "Add submission" link for:
          1. Assignment 1
          2. Assignment 2
          3. Assignment 3
        3. Confirm that you do not see an "Add submission" link for:
          1. Assignment 4
          2. Assignment 5
      3. For each "Add submission" link:
        1. Clicking on the link takes you to a page where you can submit the assignment (it has a file manager)
      4. Click on each of the Assignment names:
        1. Confirm that it takes you to a summary page for that assignment
      User overrides (scenario 1)
      1. Login as student 2
      2. In the timeline block, change the filter to "All"
      3. For the activity where you set an override:
        1. Confirm that you cannot see an "Add submission" link
      User overrides (scenario 2)
      1. Login as student 3
      2. In the timeline block, change the filter to "All"
      3. For the activity where you set an override:
        1. Confirm that you can see an "Add submission" link
        2. *Confirm that clicking the link takes you to a page to submit
      User overrides (scenario 2)
      1. Login as student 4
      2. In the timeline block, change the filter to "All"
      3. For the activity where you set an override:
        1. Confirm that you can see an "Add submission" link
        2. *Confirm that clicking the link takes you to a page to submit
      Show
      Test with both clean and boost. Prerequisites: Have timeline block in dashboard A course 4 students enrolled Create assignments for the following scenarious (1 each): Allow submissions from 5 days ago with due date 5 days in the future Add User Overrides for student 2 with Cut-off date 1 day ago, and all other dated not enabled Allow submissions from 5 days ago with Due date in 5 days AND Cut-off date in 10 days Add User Overrides for student 3 with the Due date 3 days ago, and all other dates not enabled Allow submissions from 5 days ago with Due date 3 days ago Allow submissions from 5 days ago with Due date 3 days ago and Cut-off date 2 days ago Add User Overrides for student 4 with Due date 1 day ago, cut-off date in 1 day, and other dates not enabled Allow submissions from 5 days in the future with Due date in 10 days and Cut-off date in 11 days Instructions: Login as a the first student In the timeline block, change the filter to "All" Confirm you can see all 5 assignments Confirm that you see an "Add submission" link for: Assignment 1 Assignment 2 Assignment 3 Confirm that you do not see an "Add submission" link for: Assignment 4 Assignment 5 For each "Add submission" link: Clicking on the link takes you to a page where you can submit the assignment (it has a file manager) Click on each of the Assignment names: Confirm that it takes you to a summary page for that assignment User overrides (scenario 1) Login as student 2 In the timeline block, change the filter to "All" For the activity where you set an override: Confirm that you cannot see an "Add submission" link User overrides (scenario 2) Login as student 3 In the timeline block, change the filter to "All" For the activity where you set an override: Confirm that you can see an "Add submission" link *Confirm that clicking the link takes you to a page to submit User overrides (scenario 2) Login as student 4 In the timeline block, change the filter to "All" For the activity where you set an override: Confirm that you can see an "Add submission" link *Confirm that clicking the link takes you to a page to submit
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64092-master

      Description

      1. Login as Teacher, add an assignment with a due date within 14 days back from now.
      2. In the assignment settings add a past cutoff date which is "younger" than the due date.
      3. Login as student, go to Dashboard Timeline, set Filter to "Overdue" or to 'All".
      4. Find the assignment set in Steps 1-2, and click on the link. An error screen will popup with info like this (with Developer debugging set on):

      error/nopermission

      More information about this error
       
      Debug info:
      Error code: nopermission
      $a contents:
       Stack trace:

        • line 494 of \lib\setuplib.php: moodle_exception thrown
        • line 4512 of \mod\assign\locallib.php: call to print_error()
        • line 589 of \mod\assign\locallib.php: call to assign->view_edit_submission_page()
        • line 55 of \mod\assign\view.php: call to assign->view()
      1. The problem concerns both sort orders - By dates and By courses.

      I propose that assignments with past cut-off dates be completely removed from Timeline listings - UNLESS a student has a *current* group or user override date ("extension") set in the assignment. This is like e.g. quiz closing dates & overrides operate.

      (A related question I would have is why specifically in Assignment's case the student is taken directly to the edit submission page and not to the Assignment information page - which, as far as I have been able to establish, is the case with all the other activity types. The Timeline links direct to the activity pages simply.)

      FINAL NOTE: I have labelled this as major because any teacher who uses cutoff dates within 13 or so days after the due date will find this bug VERY annoying (students will be clicking and seeing errors.). This can become a highly frequent grievance soon.

        Attachments

        1. 2018-11-19 , 21_08_28 - Dashboard - Mozilla Firefox (tryb prywatny).png
          152 kB
          Przemek Kaszubski
        2. 2018-11-19 , 21_09_02 - Error - Mozilla Firefox (tryb prywatny).png
          38 kB
          Przemek Kaszubski
        3. 2018-11-23 , 22_35_16 - Dashboard - Mozilla Firefox (tryb prywatny).png
          80 kB
          Przemek Kaszubski
        4. 2018-11-24 , 12_27_41 - Dashboard - Mozilla Firefox (tryb prywatny).png
          66 kB
          Przemek Kaszubski
        5. 2018-11-24 , 12_27_41 - Dashboard - Mozilla Firefox (tryb prywatny).png
          66 kB
          Przemek Kaszubski
        6. 2018-11-24 , 12_34_53 - Dashboard - Mozilla Firefox.png
          49 kB
          Przemek Kaszubski
        7. 2018-11-24 , 12_36_35 - Dashboard - Mozilla Firefox.png
          56 kB
          Przemek Kaszubski
        8. 35Screenshot.png
          12 kB
          Peter Dias
        9. image-2018-11-20-12-23-41-657.png
          87 kB
          Przemek Kaszubski
        10. MDL-64092_boost.PNG
          100 kB
          Anna Carissa Sadia
        11. MDL-64092_clean.PNG
          117 kB
          Anna Carissa Sadia
        12. possibleMockup.png
          39 kB
          Peter Dias

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 30 minutes
                  3h 30m