Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64117

Boost: Wrong cursor for user menu and gear icon

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.5.3
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_35_STABLE

      Description

      Since Moodle 3.5.3 the user menu in the top right and the gear icons have the cursor "auto" instead of "pointer". I observed this on https://demo.moodle.net/ with Chrome, Firefox and IE11. See attached screen recording.

      The reason this appeared in Moodle 3.5.3 is because MDL-62139 removed the href="#" from the <a> tag in theme/boost/templates/core/action_menu_trigger.mustache and lib/templates/action_menu_trigger.mustache: https://github.com/moodle/moodle/commit/e0f64e0feb2febf5173f766cb2e7f0ce4cd8372c This makes the user agent styles for clickable links no longer apply and you get the wrong cursor.

      According to Damyon Wiese in MDL-62139:
      "The screen reader will read the menu button the same with or without this href. The styling is also unchanged because it gets the styling from the .btn class. This href is never correct and useful. If javascript was no enabled (which we don't support any more) - it would look like a link that does something but it does not do anything. Basically the href is incorrect 100% of the time and it's better to exclude it."

      Note that the <a> tags here don't have the .btn class.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                tschroeder Tim Schroeder
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: