Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64124

lp defines unused capability block/lp:view

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.3, 3.6
    • Fix Version/s: 3.7
    • Component/s: Blocks
    • Testing Instructions:
      Hide
      1. Log in as admin.
      2. Visit "Site administration ► Users ► Permissions ► Capability overview".
        • Make sure the capability is 'block/lp:view' not listed.
      3. Visit "Site administration ► Users ► Permissions ► Define roles".
      4. Access to the editing page for the "Authenticated user" role. 
        • Make sure the capability 'block/lp:view' is not listed.
      Show
      Log in as admin. Visit " Site administration ► Users ► Permissions ► Capability overview ". Make sure the capability is 'block/lp:view' not listed. Visit " Site administration ► Users ► Permissions ► Define roles ". Access to the editing page for the "Authenticated user" role.  Make sure the capability 'block/lp:view' is not listed.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      master_MDL-64124

      Description

      https://github.com/moodle/moodle/blob/master/blocks/lp/db/access.php#L49

       

      the "view" capability doesn't appear to be used anywhere and was probably added accidentally.

      We should remove it, or add a call to use it in the block get_content() function.

        Attachments

        1. MDL-64124.jpg
          16 kB
          Anna Carissa Sadia

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m