Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64134

Search: Do not show header and result message when nothing is found

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Set up

      1. Create 3 users named “user 1”, “user 2”, and “user 3”
      2. Enrol all users in the same course
      3. Log in as user 1, open the message drawer and send the message “hello” to user 2
      4. Add user 2 as a contact
        • Click the ellipsis menu in the conversation and click “add contact” and then log in as user 2 and accept the contact request
      5. Log back in as user 1
      6. Open the message drawer

      No results

      1. Search for some random set of letters, e.g. dsgfgfdgdfg
      2. CONFIRM that you simply see the text “No results” and not each of the 3 result sections

      No contacts

      1. Search for “user 3”
      2. CONFIRM that you see the user under the “Non contacts” section
      3. CONFIRM that you don’t see a “contacts” section in the search results at all
      4. CONFIRM that you don’t see a “messages” section in the search results at all

      No non-contacts

      1. Search for “user 2”
      2. CONFIRM that you see the user under the “contacts” section
      3. CONFIRM that you don’t see a “non-contacts” section in the search results at all
      4. CONFIRM that you don’t see a “messages” section in the search results at all

      No contacts or non-contacts

      1. Search for “hello”
      2. CONFIRM that you see the message under the “messages” section
      3. CONFIRM that you don’t see a “non-contacts” section in the search results at all
      4. CONFIRM that you don’t see a “contacts” section in the search results at all

      All results

      1. Search for “e”
      2. *CONFIRM*that you see results in all 3 sections
      Show
      Set up Create 3 users named “user 1”, “user 2”, and “user 3” Enrol all users in the same course Log in as user 1, open the message drawer and send the message “hello” to user 2 Add user 2 as a contact Click the ellipsis menu in the conversation and click “add contact” and then log in as user 2 and accept the contact request Log back in as user 1 Open the message drawer No results Search for some random set of letters, e.g. dsgfgfdgdfg CONFIRM that you simply see the text “No results” and not each of the 3 result sections No contacts Search for “user 3” CONFIRM that you see the user under the “Non contacts” section CONFIRM that you don’t see a “contacts” section in the search results at all CONFIRM that you don’t see a “messages” section in the search results at all No non-contacts Search for “user 2” CONFIRM that you see the user under the “contacts” section CONFIRM that you don’t see a “non-contacts” section in the search results at all CONFIRM that you don’t see a “messages” section in the search results at all No contacts or non-contacts Search for “hello” CONFIRM that you see the message under the “messages” section CONFIRM that you don’t see a “non-contacts” section in the search results at all CONFIRM that you don’t see a “contacts” section in the search results at all All results Search for “e” *CONFIRM*that you see results in all 3 sections
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-64134-master

      Description

      When no contacts/non contacts/messages are found, do not show header and "No *** found" message

      Don't Do

      From MDL-64133
      When there are no results at all:

      Don't Do

        Attachments

        1. image-2019-01-17-08-28-27-288.png
          image-2019-01-17-08-28-27-288.png
          77 kB
        2. No found Do.png
          No found Do.png
          67 kB
        3. No found Dont.png
          No found Dont.png
          78 kB
        4. No results found.png
          No results found.png
          56 kB
        5. No results found 2.png
          No results found 2.png
          19 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 34 minutes
                  34m