Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64149

Remove unused badge strings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      Open the lang/en/badges.php file and check that:

      • 'authorimage' and 'authorimage_help' don't appear.
      • 'error:invalidbadgeurl' has been moved to the end of the file, under the '// Deprecated since Moodle 3.6' section.
      Show
      Open the lang/en/badges.php file and check that: 'authorimage' and 'authorimage_help' don't appear. 'error:invalidbadgeurl' has been moved to the end of the file, under the '// Deprecated since Moodle 3.6' section.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64149-master

      Description

      While reviewing the new strings added in MDL-58454 we've realised that some of them should be removed because they're not used:

      • 'error:invalidbadgeurl' was also in previous versions, but it was never used since it was added in 2.5.
      • 'authorimage' and 'authorimage_help' were added in MDL-58454 but they were never used. 

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              cameron1729, David Mudrák (@mudrd8mz), Helen Foster
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18