Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64155

Recently accessed courses and Recently accessed items blocks fail to filter out courses and activities from suspended and not current users

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Log in as admin.
      2. Create a course c1.
      3. Create a user s1.
      4. Enrol s1 in c1 as student.
      5. Create some resources/activities in c1: a page, a forum and an assignment.

      Test

      1. Log in as s1.
      2. In the Dashboard add the "Recently accessed items" block if needed.
      3. Go to c1 and click on the activities/resources: the page, the forum and the assignment.
      4. Return to the Dashboard.
      5. Confirm the "Recently accessed items" block shows the places just visited in reverse chronological order.
      6. Confirm that the "Recently accessed courses" block display de c1 course.
      7. Log in as admin.
      8. Go to c1.
      9. Go to Participants and suspend the student enrolment.
      10. Log in as s1.
      11. Confirm that the "Recently accessed items" block doesn't display the c1 activities/resources.
      12. Confirm that the "Recently accessed courses" block doesn't display de c1 course.
      Show
      Setup Log in as admin. Create a course c1. Create a user s1. Enrol s1 in c1 as student. Create some resources/activities in c1: a page, a forum and an assignment. Test Log in as s1. In the Dashboard add the "Recently accessed items" block if needed. Go to c1 and click on the activities/resources: the page, the forum and the assignment. Return to the Dashboard. Confirm the "Recently accessed items" block shows the places just visited in reverse chronological order. Confirm  that the "Recently accessed courses" block display de c1 course. Log in as admin. Go to c1. Go to Participants and suspend the student enrolment. Log in as s1. Confirm  that the "Recently accessed items" block doesn't display the c1 activities/resources. Confirm  that the "Recently accessed courses" block doesn't display de c1 course.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64155-master

      Description

      1. Log in a Teacher, create some activities (ideally with closing dates approaching) in a course, enrol a student.
      2. Log in as the student, go to Dashboard and if needed add the "Recently accessed items" block. The "Recently accessed courses" block will probably be there by default.
      3. Go the course created in Step 1, click on the activities. (If their closing dates are pending, the links should be available in the Timeline, though that is not crucial here, any way in will do.)
      4. Return to the Dashboard, refresh it, notice that the Recently accessed courses and Recently access items blocks show the places just visited in reverse chronological order.
      5. Go back to the Teacher's interface in the course, and suspend the student or enter an enrolment end date for them in the past.
      6. Go back to the Student's Dashboard and refresh it.
      7. Notice that the Recently access courses and Recently accessed items still display the names of the places from entering which the student is now prevented. Notice aso that the Course overview block (including when "Sort by last accessed" is on), will NOT list the course(s) where the student is suspended.

      I believe there should be one policy for filtering across all the Dashboard blocks, and links to visited courses and materials should be hidden from students suspended and not current in those courses.

      The very latest version of Moodle 3.6beta+ on qa.moodle.net (where I havee attested the result reported a hour ago) already contains the MDL-64063 patch, which has fixed this (or quite similar) filtering issue on the Timeline. I think we need an analogous patch for the two filters mentioned in this report.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              vmdef Víctor Déniz Falcón
              Reporter:
              pmk Przemek Kaszubski
              Peer reviewer:
              Mark Nelson
              Integrator:
              Damyon Wiese
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/18