Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64160

pre_loginpage_hook should not fire in ajax requests

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.3
    • Fix Version/s: None
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE

      Description

      There is an issue with the saml2 plugin when the session has expired and you do something like drag an drop which fires off an ajax request, and the auth plugin gets tangled up in the ajax request. See also:

      https://github.com/catalyst/moodle-auth_saml2/issues/76

      It's not really well defined what should happen here but I assume this will affect all auth plugins that use the pre_loginpage_hook. We could work around it in the plugin but it seem better than core shouldn't trigger that callback in any ajax request.

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              brendanheywood Brendan Heywood
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: